Skip to content

fix ownership #3755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix ownership #3755

wants to merge 4 commits into from

Conversation

oioki
Copy link
Member

@oioki oioki commented Jun 17, 2025

After getsentry/vroom#593, vroom container runs as non-privileged user vroom with static uid=1000. This broke some integration tests as vroom uses profiles storage as local files in /var/lib/sentry-profiles in self-hosted installations.

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (66c057b) to head (9014b1c).
Report is 6 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3755   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         183      183           
=======================================
  Hits          182      182           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this definitely verifies @hubertdeng123's assesment so thanks so much for that!

That said we are definitely not going with this <service_name>-init pattern here as services should handle these in their entry scripts. Or if this is a one time migration (doesn't look like it as busting caches did not help with the failures) we put these in the install script.

@aldy505
Copy link
Collaborator

aldy505 commented Jun 19, 2025

Closing as this is no longer the case

@aldy505 aldy505 closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants