Skip to content

SentryFeedbackWidget Improvements #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented May 27, 2025

📜 Description

  • pick screenshot
  • take screenshot
  • feedback options
Widget Picker Take Remove
a b c d

💡 Motivation and Context

Closes #2697

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

  • Document setting of navigator key
  • Document iOS/Android strings from camera roll access not needed with current setup
  • Double check Android issue with app being terminated while picking image.

Copy link
Contributor

github-actions bot commented May 27, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3687d4f

Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 97.19626% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.45%. Comparing base (c5616a6) to head (3687d4f).

Files with missing lines Patch % Lines
...utter/lib/src/feedback/sentry_feedback_widget.dart 95.53% 5 Missing ⚠️
flutter/lib/src/feedback/sentry_logo.dart 98.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2964      +/-   ##
==========================================
- Coverage   87.63%   87.45%   -0.18%     
==========================================
  Files         278      124     -154     
  Lines        9176     4448    -4728     
==========================================
- Hits         8041     3890    -4151     
+ Misses       1135      558     -577     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented May 27, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 441.35 ms 501.16 ms 59.81 ms
Size 6.54 MiB 7.53 MiB 1017.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
40680d3 323.55 ms 390.29 ms 66.73 ms
eb1a7c1 332.98 ms 381.55 ms 48.57 ms
f79eecf 341.35 ms 388.98 ms 47.63 ms
9811573 309.76 ms 402.60 ms 92.84 ms
0965b4f 522.70 ms 549.58 ms 26.88 ms
e6b16cd 523.24 ms 594.77 ms 71.53 ms
a24a1db 400.58 ms 499.75 ms 99.17 ms
66e0270 369.04 ms 431.96 ms 62.92 ms
9555112 448.81 ms 488.89 ms 40.08 ms
ab99a31 488.88 ms 506.33 ms 17.45 ms

App size

Revision Plain With Sentry Diff
40680d3 6.06 MiB 7.03 MiB 989.25 KiB
eb1a7c1 5.94 MiB 6.92 MiB 1005.76 KiB
f79eecf 6.15 MiB 7.13 MiB 1000.07 KiB
9811573 5.94 MiB 6.96 MiB 1.02 MiB
0965b4f 6.46 MiB 7.48 MiB 1.03 MiB
e6b16cd 6.35 MiB 7.33 MiB 1005.63 KiB
a24a1db 6.46 MiB 7.48 MiB 1.02 MiB
66e0270 6.35 MiB 7.35 MiB 1017.84 KiB
9555112 6.52 MiB 7.59 MiB 1.06 MiB
ab99a31 6.49 MiB 7.57 MiB 1.08 MiB

Previous results on branch: feat/imporve-user-feedback-widget

Startup times

Revision Plain With Sentry Diff
23ff8a6 493.56 ms 556.38 ms 62.82 ms
9592079 474.51 ms 530.07 ms 55.55 ms
09c60a5 454.80 ms 514.34 ms 59.54 ms
5848af1 426.16 ms 489.23 ms 63.07 ms
62f0687 457.10 ms 518.62 ms 61.52 ms

App size

Revision Plain With Sentry Diff
23ff8a6 6.44 MiB 7.50 MiB 1.05 MiB
9592079 6.44 MiB 7.51 MiB 1.06 MiB
09c60a5 6.44 MiB 7.51 MiB 1.06 MiB
5848af1 6.54 MiB 7.53 MiB 1017.67 KiB
62f0687 6.44 MiB 7.50 MiB 1.05 MiB

Copy link
Contributor

github-actions bot commented May 27, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1264.86 ms 1281.39 ms 16.53 ms
Size 7.85 MiB 9.42 MiB 1.57 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5cc82a0 1209.24 ms 1226.31 ms 17.06 ms
c19bfb6 1236.06 ms 1259.57 ms 23.51 ms
cfa25fc 1251.77 ms 1275.69 ms 23.92 ms
379d7a8 1267.65 ms 1288.39 ms 20.74 ms
08a7b4f 1277.10 ms 1303.37 ms 26.27 ms
891efac 1233.78 ms 1248.31 ms 14.53 ms
4c84e15 1264.83 ms 1282.08 ms 17.25 ms
039058a 1227.90 ms 1256.23 ms 28.34 ms
4477d2e 1203.00 ms 1225.90 ms 22.90 ms
051e97a 1245.94 ms 1249.51 ms 3.57 ms

App size

Revision Plain With Sentry Diff
5cc82a0 8.33 MiB 9.40 MiB 1.07 MiB
c19bfb6 8.34 MiB 9.65 MiB 1.31 MiB
cfa25fc 8.32 MiB 9.43 MiB 1.10 MiB
379d7a8 8.16 MiB 9.16 MiB 1.00 MiB
08a7b4f 8.16 MiB 9.16 MiB 1.01 MiB
891efac 8.28 MiB 9.34 MiB 1.06 MiB
4c84e15 8.43 MiB 10.00 MiB 1.56 MiB
039058a 8.38 MiB 9.71 MiB 1.34 MiB
4477d2e 8.32 MiB 9.38 MiB 1.06 MiB
051e97a 8.28 MiB 9.34 MiB 1.06 MiB

Previous results on branch: feat/imporve-user-feedback-widget

Startup times

Revision Plain With Sentry Diff
9592079 1244.06 ms 1258.92 ms 14.86 ms
5848af1 1242.07 ms 1258.90 ms 16.83 ms
09c60a5 1247.39 ms 1270.30 ms 22.91 ms
23ff8a6 1241.63 ms 1260.20 ms 18.57 ms
62f0687 1244.63 ms 1263.07 ms 18.44 ms

App size

Revision Plain With Sentry Diff
9592079 8.43 MiB 10.05 MiB 1.62 MiB
5848af1 7.85 MiB 9.42 MiB 1.57 MiB
09c60a5 8.43 MiB 10.05 MiB 1.62 MiB
23ff8a6 8.43 MiB 10.04 MiB 1.61 MiB
62f0687 8.43 MiB 10.04 MiB 1.61 MiB

@denrase denrase marked this pull request as ready for review May 28, 2025 15:28
@denrase denrase requested a review from ueman May 28, 2025 15:28
@denrase denrase changed the title UserFeedback Widget improvements SentryFeedbackWidget Improvements Jun 2, 2025
@denrase denrase requested a review from buenaflor June 16, 2025 08:58
@denrase denrase requested a review from buenaflor June 16, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserFeedback Widget improvements
3 participants