Prepare SDK for upcoming Session Replay API changes on Android #2977
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Prepare SDK for upcoming Session Replay API changes on Android ([#2977](https://github.com/getsentry/sentry-dart/pull/2977))If none of the above apply, you can opt out of this check by adding |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
==========================================
+ Coverage 87.62% 89.12% +1.49%
==========================================
Files 278 93 -185
Lines 9175 3098 -6077
==========================================
- Hits 8040 2761 -5279
+ Misses 1135 337 -798 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markushi
changed the title
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bf8d36c | 1238.33 ms | 1258.71 ms | 20.38 ms |
| 136c365 | 1248.12 ms | 1277.33 ms | 29.20 ms |
| 3f3ef0b | 1223.73 ms | 1237.67 ms | 13.94 ms |
| dfbe468 | 1250.73 ms | 1275.61 ms | 24.88 ms |
| ef6466d | 1209.88 ms | 1225.81 ms | 15.93 ms |
| 30c1193 | 1227.20 ms | 1235.00 ms | 7.80 ms |
| 6ec7b50 | 1239.61 ms | 1268.93 ms | 29.32 ms |
| 3e4b523 | 1260.53 ms | 1270.06 ms | 9.53 ms |
| 21d4150 | 1252.86 ms | 1280.55 ms | 27.69 ms |
| 6f3717a | 1259.84 ms | 1280.90 ms | 21.06 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bf8d36c | 8.38 MiB | 9.74 MiB | 1.36 MiB |
| 136c365 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
| 3f3ef0b | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| dfbe468 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| ef6466d | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| 30c1193 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| 6ec7b50 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
| 3e4b523 | 8.28 MiB | 9.33 MiB | 1.05 MiB |
| 21d4150 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 6f3717a | 8.33 MiB | 9.62 MiB | 1.29 MiB |
|
|
||
| if (width == 0.0 || height == 0.0 || windowWidth == 0.0 || windowHeight == 0.0) { | ||
| result.error( | ||
| "5", |
There was a problem hiding this comment.
Not sure if result.error must be processed, but I added it to prevent any division by zero
| return; | ||
| } | ||
|
|
||
| assert(config.frameRate > 0); |
There was a problem hiding this comment.
This is kind-of ugly as super.config is nullable, but config isn't
📜 Description
As it may takes some time until the first frame is drawn, we're removing the replay configuration from the
.start()call, instead the Android SDK expectsonConfigurationChanged()to be called every time the top level widget size changes.Example replay: https://sentry-sdks.sentry.io/replays/3f571c24990e4bb998b49eebef745313
The breaking changes were introduced in
sentry-java8.13.3💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps