Skip to content

replay: add sensitive content widget to default masking #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jun 13, 2025

📜 Description

Masks the SensitiveContent widget ootb for replay

TBD: check how we can add backwards compat

💡 Motivation and Context

Closes #2987

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jun 13, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- add sensitive content widget to default masking ([#2989](https://github.com/getsentry/sentry-dart/pull/2989))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 74eb694

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.09%. Comparing base (c5616a6) to head (74eb694).
Report is 10 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (c5616a6) and HEAD (74eb694). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (c5616a6) HEAD (74eb694)
9 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2989       +/-   ##
===========================================
- Coverage   87.63%   63.09%   -24.54%     
===========================================
  Files         278        4      -274     
  Lines        9176      168     -9008     
===========================================
- Hits         8041      106     -7935     
+ Misses       1135       62     -1073     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -41,6 +41,20 @@ class SentryPrivacyOptions {
mask: false,
name: 'SentryUnmask',
));
// TODO: check for Flutter version and make this testable
Copy link
Collaborator

@ueman ueman Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static const String? version = bool.hasEnvironment('FLUTTER_VERSION')
should be at least 3.33.0-0.2.pre or higher.

Ideally, you also make a check for bool.hasEnvironment('FLUTTER_VERSION') so that it tree shakes better. Calling a property on dynamic basically disables tree shaking for that property on any class. And the FLUTTER_VERSION dart define was introduced just one major Flutter version before this, which should already improve tree shaking quite a lot for most Flutter versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SensitiveContent
2 participants