-
-
Notifications
You must be signed in to change notification settings - Fork 260
Report Flutter framework feature flags #2991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ueman
wants to merge
12
commits into
getsentry:main
Choose a base branch
from
ueman:add-framework-feature-flags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+111
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2991 +/- ##
===========================================
- Coverage 87.63% 63.09% -24.55%
===========================================
Files 278 4 -274
Lines 9180 168 -9012
===========================================
- Hits 8045 106 -7939
+ Misses 1135 62 -1073 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ueman
commented
Jun 17, 2025
flutter/test/integrations/flutter_framework_feature_flag_integration_test.dart
Outdated
Show resolved
Hide resolved
buenaflor
reviewed
Jun 17, 2025
flutter/lib/src/integrations/flutter_framework_feature_flag_integration.dart
Outdated
Show resolved
Hide resolved
flutter/test/integrations/flutter_framework_feature_flag_integration_test.dart
Outdated
Show resolved
Hide resolved
ueman
commented
Jun 17, 2025
flutter/test/integrations/flutter_framework_feature_flag_integration_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
There's a Flutter framework (draft) PR that adds feature flags to Flutter itself.
This PR supports that
💡 Motivation and Context
I want know whether a specific build used one of the feature flags.
💚 How did you test it?
I didn't. I'm not really sure how to even test this with a non-flaky test.
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
I'll keep this a draft until the linked PR is merged for some time. Afterwards this PR can be landed.