Fix cell reveal when followCellExecution enabled and notebook tab not active (microsoft#250646)

* Initial plan for issue

* Fix cell reveal when followCellExecution enabled and notebook tab not active

- Add ensureNotebookEditorVisible function to bring notebook tab into view before revealing cells
- Modify runCell function to ensure notebook editor is visible when autoReveal is enabled
- Update all runCell calls to pass editorService for finding and opening notebook editor
- Fixes issue where cells were not revealed when notebook tab was not currently active

Co-authored-by: Yoyokrazy <12552271+Yoyokrazy@users.noreply.github.com>

* whitespace

* rm obvious comment + revealIfOpened

* the actual correct solution

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Yoyokrazy <12552271+Yoyokrazy@users.noreply.github.com>
Co-authored-by: Michael Lively <milively@microsoft.com>

Author: Copilot

src/vs/workbench/contrib/notebook/browser/controller/executeActions.ts

@@ -71,7 +71,7 @@ function renderAllMarkdownCells(context: INotebookActionContext): void {
 	}
 }
 
-async function runCell(editorGroupsService: IEditorGroupsService, context: INotebookActionContext): Promise<void> {
+async function runCell(editorGroupsService: IEditorGroupsService, context: INotebookActionContext, editorService?: IEditorService): Promise<void> {
 	const group = editorGroupsService.activeGroup;
 
 	if (group) {
@@ -80,6 +80,11 @@ async function runCell(editorGroupsService: IEditorGroupsService, context: INote
 		}
 	}
 
+	// If auto-reveal is enabled, ensure the notebook editor is visible before revealing cells
+	if (context.autoReveal && (context.cell || context.selectedCells?.length) && editorService) {
+		editorService.openEditor({ resource: context.notebookEditor.textModel.uri, options: { revealIfOpened: true } });
+	}
+
 	if (context.ui && context.cell) {
 		if (context.autoReveal) {
 			handleAutoReveal(context.cell, context.notebookEditor);
@@ -284,6 +289,7 @@ registerAction2(class ExecuteCell extends NotebookMultiCellAction {
 
 	async runWithContext(accessor: ServicesAccessor, context: INotebookCommandContext | INotebookCellToolbarActionContext): Promise<void> {
 		const editorGroupsService = accessor.get(IEditorGroupsService);
+		const editorService = accessor.get(IEditorService);
 
 		if (context.ui) {
 			await context.notebookEditor.focusNotebookCell(context.cell, 'container', { skipReveal: true });
@@ -304,7 +310,7 @@ registerAction2(class ExecuteCell extends NotebookMultiCellAction {
 			return;
 		}
 
-		await runCell(editorGroupsService, context);
+		await runCell(editorGroupsService, context, editorService);
 	}
 });
 
@@ -422,6 +428,7 @@ registerAction2(class ExecuteCellFocusContainer extends NotebookMultiCellAction
 
 	async runWithContext(accessor: ServicesAccessor, context: INotebookCommandContext | INotebookCellToolbarActionContext): Promise<void> {
 		const editorGroupsService = accessor.get(IEditorGroupsService);
+		const editorService = accessor.get(IEditorService);
 
 		if (context.ui) {
 			await context.notebookEditor.focusNotebookCell(context.cell, 'container', { skipReveal: true });
@@ -433,7 +440,7 @@ registerAction2(class ExecuteCellFocusContainer extends NotebookMultiCellAction
 			}
 		}
 
-		await runCell(editorGroupsService, context);
+		await runCell(editorGroupsService, context, editorService);
 	}
 });
 
@@ -526,6 +533,7 @@ registerAction2(class ExecuteCellSelectBelow extends NotebookCellAction {
 
 	async runWithContext(accessor: ServicesAccessor, context: INotebookCellActionContext): Promise<void> {
 		const editorGroupsService = accessor.get(IEditorGroupsService);
+		const editorService = accessor.get(IEditorService);
 		const idx = context.notebookEditor.getCellIndex(context.cell);
 		if (typeof idx !== 'number') {
 			return;
@@ -568,7 +576,7 @@ registerAction2(class ExecuteCellSelectBelow extends NotebookCellAction {
 				}
 			}
 
-			return runCell(editorGroupsService, context);
+			return runCell(editorGroupsService, context, editorService);
 		}
 	}
 });
@@ -589,6 +597,7 @@ registerAction2(class ExecuteCellInsertBelow extends NotebookCellAction {
 
 	async runWithContext(accessor: ServicesAccessor, context: INotebookCellActionContext): Promise<void> {
 		const editorGroupsService = accessor.get(IEditorGroupsService);
+		const editorService = accessor.get(IEditorService);
 		const idx = context.notebookEditor.getCellIndex(context.cell);
 		const languageService = accessor.get(ILanguageService);
 		const newFocusMode = context.cell.focusMode === CellFocusMode.Editor ? 'editor' : 'container';
@@ -601,7 +610,7 @@ registerAction2(class ExecuteCellInsertBelow extends NotebookCellAction {
 		if (context.cell.cellKind === CellKind.Markup) {
 			context.cell.updateEditState(CellEditState.Preview, EXECUTE_CELL_INSERT_BELOW);
 		} else {
-			runCell(editorGroupsService, context);
+			runCell(editorGroupsService, context, editorService);
 		}
 	}
 });