-
Notifications
You must be signed in to change notification settings - Fork 414
feat(cmd/gno): fix
subcommand
#4404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thehowl
wants to merge
8
commits into
gnolang:master
Choose a base branch
from
thehowl:dev/morgan/gno-fix-alt-trans
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-implementation of #4100, which uses the same framework it introduces and adapts the current transpiler (for gno 0.9) to it.
This is an alternative approach, that instead of being based on the Gno AST, it works with the Go AST and thus is able to reach similar objectives with less code.
This gist shows the difference between the state of
examples
in 62a16f0, and what is generated bygno fix -fix interrealm
instead.The transpiler leaves code in a state where it likely still need fixes; mostly because crossing functions change signatures, but their usage is not updated if the caller did not use
cross()
, which can happen for calls within the same package. All of the errors printed bygno lint
afterwards are about too many or too few arguments passed to functions.Why we should go with an AST analysis instead of the transpiler on master:
I decided to rewrite the 0.9 transpiler because most of what needed to be transpiled had to be transpiled anyway, and I believe the approach in this PR is cleaner over the long term.