Skip to content

feat(cmd/gno): fix subcommand #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jun 23, 2025

This is a re-implementation of #4100, which uses the same framework it introduces and adapts the current transpiler (for gno 0.9) to it.

This is an alternative approach, that instead of being based on the Gno AST, it works with the Go AST and thus is able to reach similar objectives with less code.

This gist shows the difference between the state of examples in 62a16f0, and what is generated by gno fix -fix interrealm instead.

The transpiler leaves code in a state where it likely still need fixes; mostly because crossing functions change signatures, but their usage is not updated if the caller did not use cross(), which can happen for calls within the same package. All of the errors printed by gno lint afterwards are about too many or too few arguments passed to functions.

Why we should go with an AST analysis instead of the transpiler on master:

  • The AST type checker is faster, and simpler to write more fixes for.
  • It doesn't require types to make sense, and thus doesn't require a complete understanding of how Gno used to work in a previous version (unless the syntax of the language changes)

I decided to rewrite the 0.9 transpiler because most of what needed to be transpiled had to be transpiled anyway, and I believe the approach in this PR is cleaner over the long term.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jun 23, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Jun 23, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: No status
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants