-
Notifications
You must be signed in to change notification settings - Fork 415
feat(gnovm): gnomod.toml add new field draft
#4413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(gnovm): gnomod.toml add new field draft
#4413
Conversation
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
…o mikaelvallenet/gnovm/gnomod/add-new-draft-field
draft
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
## Description Renaming to Gno.land, adding back in the gnoclient docs that were dropped with the Docs V2.
## Description Fixing the coin checker so it supports the newest gno-forms PR. The issue was that the form can only take you to a pre-determined render path within the realm, without the ability to parametrize it. I had to switch to parametrizing via query parameters. Would appreciate if someone can play around a bit.
## Description Fixes outdated link.
…o mikaelvallenet/gnovm/gnomod/add-new-draft-field
…o mikaelvallenet/gnovm/gnomod/add-new-draft-field
…kg at non genesis time
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
gnovm/pkg/gnolang/gotypecheck.go
Outdated
TCLatestStrict TypeCheckMode = iota // require latest gno.mod gno version. | ||
TCGLatestForbidDraftImp // require latest gno.mod gno version, but forbid import draft packages too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TCLatestStrict TypeCheckMode = iota // require latest gno.mod gno version. | |
TCGLatestForbidDraftImp // require latest gno.mod gno version, but forbid import draft packages too | |
TCLatestStrict TypeCheckMode = iota // require latest gnomod gno version, forbid draft. | |
TCGenesisStrict // require latest gnomod gno version, allow drafts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied here: e059379
however i'm not convinced, run txs use TCLatestRelaxed, if we want to switch run txs to Strict check mode and decide to use TCLatestStrict, we will then block draft import for txs run without explicit way to see it except the comment next to the declaration of TCLatestStrict.
We could also migrate typecheckmode to a struct or interface that could make available some informations like (tx type [run, send, call, addpkg ...], height int, strict bool)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After my last comment, it looks good to me.
However, let's wait for a few more reviews, at least from 2 or 3 of @jaekwon, @thehowl, and @ltzmaxwell.
fix second task of #4370
depends on #4407 (approved but not merged yet)