Skip to content

feat(gnovm): gnomod.toml add new field draft #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

MikaelVallenet
Copy link
Member

fix second task of #4370
depends on #4407 (approved but not merged yet)

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jun 24, 2025
@MikaelVallenet MikaelVallenet changed the title feat(gnovm): gnomod.toml add new field draft feat(gnovm): gnomod.toml add new field draft Jun 24, 2025
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jun 24, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jun 24, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: MikaelVallenet/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 And
            ├── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
            └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 43.33333% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/gotypecheck.go 15.00% 14 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

leohhhn and others added 7 commits June 25, 2025 11:43
## Description

Renaming to Gno.land, adding back in the gnoclient docs that were
dropped with the Docs V2.
## Description

Fixing the coin checker so it supports the newest gno-forms PR.

The issue was that the form can only take you to a pre-determined render
path within the realm, without the ability to parametrize it. I had to
switch to parametrizing via query parameters. Would appreciate if
someone can play around a bit.
## Description

Fixes outdated link.
…o mikaelvallenet/gnovm/gnomod/add-new-draft-field
@Kouteki Kouteki moved this from Triage to In Review in 🧙‍♂️gno.land core team Jun 30, 2025
@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Jun 30, 2025
Comment on lines 132 to 133
TCLatestStrict TypeCheckMode = iota // require latest gno.mod gno version.
TCGLatestForbidDraftImp // require latest gno.mod gno version, but forbid import draft packages too
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TCLatestStrict TypeCheckMode = iota // require latest gno.mod gno version.
TCGLatestForbidDraftImp // require latest gno.mod gno version, but forbid import draft packages too
TCLatestStrict TypeCheckMode = iota // require latest gnomod gno version, forbid draft.
TCGenesisStrict // require latest gnomod gno version, allow drafts.

Copy link
Member Author

@MikaelVallenet MikaelVallenet Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied here: e059379
however i'm not convinced, run txs use TCLatestRelaxed, if we want to switch run txs to Strict check mode and decide to use TCLatestStrict, we will then block draft import for txs run without explicit way to see it except the comment next to the declaration of TCLatestStrict.

We could also migrate typecheckmode to a struct or interface that could make available some informations like (tx type [run, send, call, addpkg ...], height int, strict bool)

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my last comment, it looks good to me.

However, let's wait for a few more reviews, at least from 2 or 3 of @jaekwon, @thehowl, and @ltzmaxwell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: In Progress
Status: In Review
Development

Successfully merging this pull request may close these issues.

5 participants