Skip to content

pubsub: update context handling in tracer end calls #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lwbio
Copy link

@lwbio lwbio commented Jun 24, 2025

tracer.End should use ctx from trace.Start, since it use some values from start;
Otherwise
panic: interface conversion: interface {} is nil, not time.Time

Copy link

google-cla bot commented Jun 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vangent
Copy link
Contributor

vangent commented Jun 28, 2025

Thanks for the fix; I haven't merged it because the tests are failing, but it's not due to this PR. The contribution that added OpenTelemetry support appear to have been problematic, and I'm trying to figure out what to do.

@vangent
Copy link
Contributor

vangent commented Jun 28, 2025

I've rolled back the commit that introduced this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants