Allow calls to Objects.hash with a null varargs array.
#127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation if anything implies that a null array is _not_ allowed. But it is, since the method delegates straight to `Arrays.hashCode`, which accepts `null` (and even documents as much). The JDK would be within its rights to change that in the future, but I can't imagine they would risk the compatibility problems it would cause. I do grant that it's somewhat unlikely that callers would pass a null array. The reason that I care is that I'm looking at making Guava's ancient [`Objects.hashCode`](https://github.com/google/guava/blob/990557ca1295e068e7a83a0ee4556ccbca2bc240/guava/src/com/google/common/base/Objects.java#L76) call Java's `Objects.hash`-leading to a nullness error with the current JDK stubs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation if anything implies that a null array is not
allowed. But it is, since the method delegates straight to
Arrays.hashCode, which acceptsnull(and even documents as much).The JDK would be within its rights to change that in the future, but I
can't imagine they would risk the compatibility problems it would cause.
I do grant that it's somewhat unlikely that callers would pass a null
array. The reason that I care is that I'm looking at making Guava's
ancient
Objects.hashCodecall Java's
Objects.hash—leading to a nullness error with the currentJDK stubs.