Skip to content

feat: add Falco provider integration with documentation and tests #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

knownasmobin
Copy link
Contributor

Closes #5024

📑 Description

This PR adds support for a new Falco provider, updates documentation, and ensures coverage via unit tests. Specifically:

  • Implement Falco provider
  • Document Falco integration and add to docs index
  • Add Keep doc snippet for Falco
  • Register Falco in README provider list
  • Add basic unit test
  • Fix FalcoProvider test imports
  • Decouple unit test from heavy dependencies

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Testing

  • Render docs snippets:

    ~/.pyenv/versions/3.11.12/bin/python scripts/docs_render_provider_snippets.py
  • Run Falco provider tests:

    ~/.pyenv/versions/3.11.12/bin/python -m unittest tests.test_falco_provider -v

Copy link

vercel bot commented Jun 14, 2025

@knownasmobin is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 14, 2025
Copy link

cursor bot commented Jun 14, 2025

🚨 BugBot couldn't run

Pull requests from forked repositories are not yet supported (requestId: serverGenReqId_866e739b-3b63-4724-9d3a-3322938f56e4).

@dosubot dosubot bot added Documentation Improvements or additions to documentation Feature A new feature Provider Providers related issues labels Jun 14, 2025
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing - can you make them pass?

@shahargl
Copy link
Member

@knownasmobin is it relevant?

@knownasmobin
Copy link
Contributor Author

@knownasmobin is it relevant?

I’ll check it out shortly and address it

@talboren
Copy link
Member

Closing for now as this is stale for 2 weeks. If this is still relevant, please re-open the issue @knownasmobin 🙏🏼

@talboren talboren closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Feature A new feature Provider Providers related issues size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔌 Provider]: Falco
3 participants