Skip to content

Add 3D semantic segmentation code example #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

innat
Copy link
Contributor

@innat innat commented May 3, 2025

@innat
Copy link
Contributor Author

innat commented May 3, 2025

@mattdangerw
I addressed all the feedback you made here. Please check it.

@innat
Copy link
Contributor Author

innat commented May 7, 2025

@mattdangerw
A gentle reminder.

@innat
Copy link
Contributor Author

innat commented May 15, 2025

@mattdangerw
Could you please take a look this PR? Is it suitable for keras code example, otherwise I will close the PR.

@divyashreepathihalli
Copy link
Collaborator

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code changes introduce a 3D semantic segmentation pipeline for medical imaging, specifically brain tumor segmentation using the BraTS dataset. The code is well-structured, but there are opportunities to improve maintainability, clarity, and correctness through refactoring repetitive code blocks, clarifying visualization logic, and simplifying computations.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@innat
Copy link
Contributor Author

innat commented Jul 13, 2025

@divyashreepathihalli
A review from human would be appreciated. Thanks.

Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! please generate the rest of the files! thank you!

@innat
Copy link
Contributor Author

innat commented Jul 23, 2025

@divyashreepathihalli
I got

ValueError: Found 437 lines of code, but expected fewer than 350

Is it possible to allow more lines than expected?

Edits

I’ve made an effort to reduce the amount of code, but each part is important for conveying the complete picture. BraTS is a complex problem, and solving it effectively requires a thorough and well-demonstrated approach. My reasoning is that the additional lines of code are both relevant and necessary to present an end-to-end, understandable example. With that in mind, I’d like to request an exception to allow a higher LOC than typically expected in this case.

@innat
Copy link
Contributor Author

innat commented Jul 23, 2025

cc @fchollet ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants