-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix: cooldown reset on pod restart #8057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MenD32
wants to merge
34
commits into
kubernetes:master
Choose a base branch
from
MenD32:fix/cooldown-reset-on-pod-redeploy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
f31f6ac
feat: added MaxDeletionCandidateStaleness
MenD32 0af55ac
refactor: added description comments for public functions
MenD32 be3a1b9
fix: PR comments
MenD32 98949f0
fix: PR comments
MenD32 5664908
fix: PR comments
MenD32 6590d55
fix: PR comments
MenD32 2835740
tests: debugging TestStaticAutoscalerRunOnceWithExistingDeletionCandi…
MenD32 32fafcf
Merge branch 'master' into fix/max-deletion-candidate-staleness
MenD32 387d146
tests: debugging TestStaticAutoscalerRunOnceWithExistingDeletionCandi…
MenD32 714bc68
tests: debugging TestStaticAutoscalerRunOnceWithExistingDeletionCandi…
MenD32 531feb3
Merge branch 'master' into fix/max-deletion-candidate-staleness
MenD32 0203ab6
Merge branch 'master' into fix/max-deletion-candidate-staleness
MenD32 3a1ae27
fix: changed maxDeletionCandidateStaleness to maxDeletionCandidateTTL…
MenD32 422d17f
fix: typo in function name updateInternalState
MenD32 30b5cdb
fix: cleaned up unneeded nodes loading
MenD32 4b09315
fix: cleared up taint staleness log
MenD32 3f7b299
fix: removed old comment
MenD32 412fb48
fix: fixed log on node skip due to stale deleltionCandidate taint
MenD32 837c330
fix: changed log from plural to singular
MenD32 899abd6
refactor: removed old flag naming maxDeletionCandidateTTL -> nodeDele…
MenD32 a27cd62
fix: simplified CleanAllTaints' logic of ignoring nodes without taintKey
MenD32 f5e1172
fix: moved taint cleaning from static_autoscaler initialization to sc…
MenD32 b4c3661
fix: gofmt on flags.go
MenD32 43b5ba9
fix: add check to planner.New() that allnodelister isn't nil
MenD32 b8890bf
fix: add check to planner.New() that allnodelister isn't nil
MenD32 713b9c3
fix: taint deleting made conditional on non-default deletionCandidate…
MenD32 95bc665
tests: moved tests of deletionCandidate taint management from static_…
MenD32 4d790ba
tests: moved tests of deletionCandidate taint management from static_…
MenD32 f63a66a
tests: readded TestStaticAutoscalerRunOnceWithExistingDeletionCandida…
MenD32 ddf3d0a
lint: added comment to NewDynamicTestNodeLister
MenD32 5f818ca
lint: added comment to NewDynamicTestNodeLister
MenD32 de0f705
fix: added DeletionCandidateStalenessTTL on new nodes when intializin…
MenD32 10e656f
fix: build error on unneeded/nodes_test.go
MenD32 7d15006
fix(tests): bad DeletionCandidateStalenessTTL in TestNodeLoadFromExis…
MenD32 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is just a type I noticed, I can revert if that's an issue