-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Handle node readiness for DRA after a scale-up #8109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle node readiness for DRA after a scale-up #8109
Conversation
Hi @abdelrahman882. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cd12d1e
to
325556c
Compare
cluster-autoscaler/processors/customresources/multiple_custom_processor.go
Outdated
Show resolved
Hide resolved
325556c
to
9d86f05
Compare
2106a4f
to
8252cc8
Compare
37974ec
to
c15a122
Compare
cluster-autoscaler/processors/customresources/gpu_processor_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/customresources/default_custom_processor_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/customresources/dra_processor_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/customresources/dra_processor_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/customresources/dra_processor_test.go
Outdated
Show resolved
Hide resolved
c15a122
to
92eab49
Compare
cluster-autoscaler/processors/customresources/default_custom_processor_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/customresources/default_custom_processor_test.go
Show resolved
Hide resolved
cluster-autoscaler/processors/customresources/default_custom_processor_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/customresources/dra_processor_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/customresources/dra_processor_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/customresources/dra_processor_test.go
Outdated
Show resolved
Hide resolved
92eab49
to
9ede622
Compare
Thanks for addressing all the comments @abdelrahman882! LGTM from my end, holding for @jackfrancis to LGTM as well. /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abdelrahman882, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm sorry about the rebase need @abdelrahman882, but it'll have the side-effect of addressing the UT failure :) |
9ede622
to
b07e1e4
Compare
@towca @jackfrancis Rebased and ready for merging |
/lgtm |
/test pull-cluster-autoscaler-e2e-azure-master |
/unhold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a custom resource processor that marks node with unready DRA reasources as unready node so that CA doesn't create another unnecessary scale-ups for the pods that wouldn't get scheduled on nodes with unready resources.
Which issue(s) this PR fixes:
Fixes #7780
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: