Skip to content

Use PartialObjectMetadata for ConfigMaps and Secrets #2463

Open
@mrueg

Description

@mrueg

What would you like to be added:
We should look into allowing to fetch only PartialObjectMetadata for these configmap/secrets objects.

Why is this needed:
ConfigMap objects can contain up to 1M of config or binary data. The metrics generated for the configmap is only relying on metadata.
Using PartialObjectMetadata will reduce memory consumption of KSM and require less network traffic.

For Secrets I think this will add the benefit that the secret data never is requested over the wire.

Describe the solution you'd like
Probably this metadatalister can be used instead of the ListWatch we use for other objects.
https://github.com/kubernetes/client-go/blob/71959c526d543a5e4c3ca6fb808f535c2726483f/metadata/metadatalister/lister.go

Additional context

Activity

added
kind/featureCategorizes issue or PR as related to a new feature.
on Aug 5, 2024
added
needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
on Aug 5, 2024
changed the title [-]Use PartialObjectMetadata for ConfigMaps[/-] [+]Use PartialObjectMetadata for ConfigMaps and Secrets[/+] on Aug 5, 2024
linked a pull request that will close this issue on Aug 6, 2024
dgrisonnet

dgrisonnet commented on Aug 8, 2024

@dgrisonnet
Member

/assign @mrueg
/triage accepted

added
triage/acceptedIndicates an issue or PR is ready to be actively worked on.
and removed
needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
on Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

kind/featureCategorizes issue or PR as related to a new feature.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @mrueg@k8s-ci-robot@dgrisonnet

    Issue actions

      Use PartialObjectMetadata for ConfigMaps and Secrets · Issue #2463 · kubernetes/kube-state-metrics