Fix minikube image load on windows (#20529) #20921
Conversation
|
|
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @james-world! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @james-world. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
|
Can one of the admins verify this patch? |
k8s-ci-robot
added
cncf-cla: yes
james-world
changed the title
james-world
force-pushed
the
fix-20529
branch
2 times, most recently
from
7a66934 to
211296e
Compare
k8s-ci-robot
added
size/M
|
If powershell.exe is not available in PATH (it should be...) it can be discovered via |
|
OK, sorry for the hiatus - been busy at work. @medyagh I've removed the fallback as discussed and added code to robustly discover Powershell.exe, using the cited approaches. |
|
thank you @james-world, let me ask @bobsira for last approve and then we can merge it |
There was a problem hiding this comment.
Tested this on Windows machine, works fine! Approved @medyagh
Had a successful run with the changes,
`C:\dev\minikube\out>minikube.exe image load nginx:latest --alsologtostderr I0714 02:30:21.918732 24816 out.go:345] Setting OutFile to fd 96 ... I0714 02:30:21.949424 24816 out.go:392] TERM=,COLORTERM=, which probably does not support color I0714 02:30:21.949424 24816 out.go:358] Setting ErrFile to fd 100... I0714 02:30:21.950091 24816 out.go:392] TERM=,COLORTERM=, which probably does not support color I0714 02:30:21.969639 24816 config.go:182] Loaded profile config "minikube": Driver=hyperv, ContainerRuntime=docker,
KubernetesVersion=v1.33.2
=== some of the logs removed to have this fit in the comment
I0714 02:30:36.438734 24816 cache_images.go:123] Successfully loaded all cached images I0714 02:30:36.438734 24816 cache_images.go:92] duration metric: took 5.9631078s to LoadCachedImages I0714 02:30:36.439366 24816 cache_images.go:262] succeeded pushing to: minikube `
|
@james-world plz see last comments and then we can merge this |
getWindowsVolumeNameCmd uses the deprecated wmic.exe. See https://learn.microsoft.com/en-us/windows/win32/wmisdk/wmic for details. Replace the implementation with a call to the Powershell equivalent. Look in path and system environment vars to locate Powershell. Improve Powershell discovery
|
@medyagh Added the requested comment. |
|
thank you @james-world |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 driver with docker runtime Times for minikube start: 49.2s 50.9s 48.2s 48.4s 50.8s Times for minikube ingress: 15.0s 15.0s 15.0s 14.9s 14.9s docker driver with docker runtime Times for minikube start: 25.2s 22.3s 21.8s 26.9s 23.1s Times for minikube ingress: 10.7s 12.7s 12.7s 12.7s 12.7s docker driver with containerd runtime Times for minikube start: 24.1s 24.1s 23.5s 21.0s 24.1s Times for minikube ingress: 22.7s 38.8s 38.7s 23.3s 22.7s |
|
The failures seem unrelated to this PR (failed to pull an image) |
|
@medyagh I've started to see this kind of error at work; it's docker.io rate-limiting. Definitely nothing to do with this PR. The rate limiting on anonymous logins is by IP - see here. That means if you are using any shared IP on the build agent pool you can hit limits faster than you might think. We've addressed it by using pull-through caches (we use ACR for this: https://learn.microsoft.com/en-us/azure/container-registry/artifact-cache-overview) Guess minikube would need to cut a deal with docker.io, or do something similar. |
|
@medyagh Just following up on this - not sure what else I can do? I'm pretty sure the build failure here is an unrelated transient issue with throttled image pulls from docker registry. Anything I can do to help move it along? |
thank you for sharing that I will check that out. we have two different rate limit issue, I will checkout the caching you have linked |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: james-world, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
thank you very much @james-world for your patience and presistance and making minikube better for our windows users, I look forward to see more contributions from you, maybe you could join one of our Office Hours or Triage Parties |
getWindowsVolumeNameCmd uses the deprecated wmic.exe. See https://learn.microsoft.com/en-us/windows/win32/wmisdk/wmic for details. Replace the implementation with a call to the Powershell equivalent. Look in path and system environment vars to locate Powershell. Improve Powershell discovery
getWindowsVolumeNameCmd uses the deprecated wmic.exe. See https://learn.microsoft.com/en-us/windows/win32/wmisdk/wmic for details. Replace the implementation with a call to the Powershell equivalent. Look in path and system environment vars to locate Powershell. Improve Powershell discovery
getWindowsVolumeNameCmd uses the deprecated wmic.exe. See https://learn.microsoft.com/en-us/windows/win32/wmisdk/wmic for details. Replace the implementation with a call to the Powershell equivalent. Look in path and system environment vars to locate Powershell. Improve Powershell discovery
fixes #20529
getWindowsVolumeNameCmduses the deprecated wmic.exe, this breaksminikube image loadon newer installs of windows. Whilst wmic.exe can be added, it will be removed from Windows 11 soon.See here for details.
This fix replaces the use of
wmic.exewith a call to the Powershell equivalent.