Create URIs (w3id.org PURLs) for Enums in same style as for classes & slots #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 64.45% 64.49% +0.03%
==========================================
Files 62 62
Lines 8846 8849 +3
Branches 2556 2557 +1
==========================================
+ Hits 5702 5707 +5
+ Misses 2535 2533 -2
Partials 609 609 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dalito
force-pushed
the
issue2710-PURL-links-for-enums
branch
from
56f0ddf to
4e0b501
Compare
ialarmedalien
approved these changes
Jun 16, 2025
dalito
force-pushed
the
issue2710-PURL-links-for-enums
branch
from
4e0b501 to
a8e815a
Compare
sierra-moxon
approved these changes
Jul 14, 2025
dalito
force-pushed
the
issue2710-PURL-links-for-enums
branch
from
ee25d6d to
d35ad59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was marked as "todo" for schemaview in linkml
gen-doc(see linked issue) but never done.I tried to find out why this URI-generation was not implemented from the beginning but could not find anything. So I believe it is Ok to add it now. Happy to get some feedback on this.
@sierra-moxon This is again (my specialty) an issue which will make linkml test suite fail until the corresponding PR in linkml linkml/linkml#2711 is also merged.
Related to linkml/linkml#2710