Improve flight path calculation with loiter radius support #13024
+127
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the adjustCoordinatesForLoiterRadius() method to correctly calculate tangent points for flight paths connecting loiter circles. The implementation: - Handles connections between two loiter circles using proper tangent calculation - Supports connections between a point and a loiter circle - Adjusts display coordinates while preserving the original waypoint positions - Uses geometric calculations based on azimuth and distance between waypoints This ensures correctly visualized flight paths when mission items include loiter commands.
|
This change is based on my current understanding of QGC, though I realize it may not be an ideal solution. |
|
Haven't looked at the implementation yet but this was much needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the adjustCoordinatesForLoiterRadius() method to correctly calculate tangent points for flight paths connecting loiter circles. The implementation: