Fix issue #78: jwtMiddleware throws at startup #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add error handling in `verifyToken` function in `jwt-middleware.ts` to catch and log errors from `ServerResponse.setHeader`. * Catch and log errors in `verifyToken` function * Throw the caught error to propagate it further --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/Agents-for-js?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling in the verifyToken function to catch, log, and rethrow errors during JWT verification.
- Added a
.catchblock on the Promise returned byverifyTokento log errors. - Ensures errors are propagated after logging.
Comments suppressed due to low confidence (1)
packages/agents-hosting/src/auth/jwt-middleware.ts:64
- Add a unit test covering the error path in
verifyTokento verify that errors are properly logged and rethrown.
logger.error('Error in verifyToken: ', err)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error handling in
verifyTokenfunction injwt-middleware.tsto catch and log errors fromServerResponse.setHeader.verifyTokenfunctionFor more details, open the Copilot Workspace session.