Fix collisions in indirect sqlproj dependencies for separate databases #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using transitive project references in SQL projects (where Project A references Project B, which references Project C), database variables were not properly preserved between projects. This caused name collisions when multiple projects contained objects with the same name, even though those objects were intended to be in separate databases.
For example:
When building Sql3, the build would fail with collisions between Table1 objects, even though they should be considered as objects in separate databases.
Solution
The fix adds a target that runs after ResolveArtifactReferences to ensure that the DatabaseSqlCmdVariable metadata (and other database reference metadata) are preserved in transitive project references. This allows the build system to correctly identify that tables with the same name are actually in different databases when connected via the project reference chain.
Details of Changes
Testing
Added a test case that verifies build succeeds with transitive project references where all projects have objects with the same name but are marked as separate databases using DatabaseSqlCmdVariable.
Fixes #608.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
crl3.digicert.com
dotnet build
(dns block)crl4.digicert.com
dotnet build
(dns block)ocsp.digicert.com
dotnet build
(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js
(dns block)s.symcb.com
dotnet build
(dns block)s.symcd.com
dotnet build
(dns block)ts-crl.ws.symantec.com
dotnet build
(dns block)ts-ocsp.ws.symantec.com
dotnet build
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.