Skip to content

Fix collisions in indirect sqlproj dependencies for separate databases #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented May 22, 2025

Issue

When using transitive project references in SQL projects (where Project A references Project B, which references Project C), database variables were not properly preserved between projects. This caused name collisions when multiple projects contained objects with the same name, even though those objects were intended to be in separate databases.

For example:

  • Sql1 contains a Table1
  • Sql2 references Sql1 with DatabaseSqlCmdVariable="Sql1" and contains its own Table1
  • Sql3 references Sql2 with DatabaseSqlCmdVariable="Sql2" and contains its own Table1

When building Sql3, the build would fail with collisions between Table1 objects, even though they should be considered as objects in separate databases.

Solution

The fix adds a target that runs after ResolveArtifactReferences to ensure that the DatabaseSqlCmdVariable metadata (and other database reference metadata) are preserved in transitive project references. This allows the build system to correctly identify that tables with the same name are actually in different databases when connected via the project reference chain.

Details of Changes

  1. Added a PreserveProjectReferenceDatabaseMetadata target in Sdk.targets that preserves DatabaseSqlCmdVariable, ServerSqlCmdVariable, and DatabaseVariableLiteralValue metadata from project references
  2. Created a test that reproduces the issue and verifies the fix works correctly

Testing

Added a test case that verifies build succeeds with transitive project references where all projects have objects with the same name but are marked as separate databases using DatabaseSqlCmdVariable.

Fixes #608.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • crl3.digicert.com
    • Triggering command: dotnet build (dns block)
  • crl4.digicert.com
    • Triggering command: dotnet build (dns block)
  • ocsp.digicert.com
    • Triggering command: dotnet build (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • s.symcb.com
    • Triggering command: dotnet build (dns block)
  • s.symcd.com
    • Triggering command: dotnet build (dns block)
  • ts-crl.ws.symantec.com
    • Triggering command: dotnet build (dns block)
  • ts-ocsp.ws.symantec.com
    • Triggering command: dotnet build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits May 22, 2025 20:44
Co-authored-by: zijchen <13544267+zijchen@users.noreply.github.com>
…CmdVariable

Co-authored-by: zijchen <13544267+zijchen@users.noreply.github.com>
…CmdVariable metadata

Co-authored-by: zijchen <13544267+zijchen@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Collisions in indirect sqlproj dependencies for separate databases Fix collisions in indirect sqlproj dependencies for separate databases May 22, 2025
@Copilot Copilot AI requested a review from zijchen May 22, 2025 21:01
Copilot finished work on behalf of zijchen May 22, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collisions in indirect sqlproj dependencies for separate databases
2 participants