Skip to content

Lakeshore driver improvments #7187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 2, 2025
Merged

Conversation

jenshnielsen
Copy link
Collaborator

Followup to the fixes that landed in #7184

  • Make sure that submodules of the lakeshore driver are statically defined and documented
  • Remove deprecated aliases from qcodes.instrument_drivers.Lakeshore.lakeshore_base.py
  • Deprecate aliases for Lakeshore without maker name of the form Model_...

@jenshnielsen jenshnielsen marked this pull request as ready for review May 30, 2025 11:07
@jenshnielsen jenshnielsen requested a review from a team as a code owner May 30, 2025 11:07
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 65.38462% with 18 lines in your changes missing coverage. Please review.

Project coverage is 59.93%. Comparing base (d3135df) to head (096e70e).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...nstrument_drivers/Lakeshore/Lakeshore_model_325.py 0.00% 18 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7187   +/-   ##
=======================================
  Coverage   59.92%   59.93%           
=======================================
  Files         342      342           
  Lines       31481    31504   +23     
=======================================
+ Hits        18865    18881   +16     
- Misses      12616    12623    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@astafan8 astafan8 enabled auto-merge June 2, 2025 13:32
@astafan8 astafan8 added this pull request to the merge queue Jun 2, 2025
Merged via the queue into microsoft:main with commit 47d7f5f Jun 2, 2025
16 checks passed
@jenshnielsen jenshnielsen deleted the lakeshore_cleanup branch June 2, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants