Skip to content

Commit 6121f45

Browse files
Renegade334Renegade334
authored
lib.es2017: Move SharedArrayBuffer[Symbol.species] onto constructor interface (#61271)
1 parent b97eafb commit 6121f45

9 files changed

+56
-56
lines changed

‎src/lib/es2017.sharedmemory.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ interface SharedArrayBuffer {
1111
* Returns a section of an SharedArrayBuffer.
1212
*/
1313
slice(begin?: number, end?: number): SharedArrayBuffer;
14-
readonly [Symbol.species]: SharedArrayBuffer;
1514
readonly [Symbol.toStringTag]: "SharedArrayBuffer";
1615
}
1716

1817
interface SharedArrayBufferConstructor {
1918
readonly prototype: SharedArrayBuffer;
2019
new (byteLength?: number): SharedArrayBuffer;
20+
readonly [Symbol.species]: SharedArrayBufferConstructor;
2121
}
2222
declare var SharedArrayBuffer: SharedArrayBufferConstructor;
2323

‎tests/baselines/reference/useSharedArrayBuffer4.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
//// [useSharedArrayBuffer4.ts]
44
var foge = new SharedArrayBuffer(1024);
55
var bar = foge.slice(1, 10);
6-
var species = foge[Symbol.species];
76
var stringTag = foge[Symbol.toStringTag];
8-
var len = foge.byteLength;
7+
var len = foge.byteLength;
8+
var species = SharedArrayBuffer[Symbol.species];
99

1010
//// [useSharedArrayBuffer4.js]
1111
var foge = new SharedArrayBuffer(1024);
1212
var bar = foge.slice(1, 10);
13-
var species = foge[Symbol.species];
1413
var stringTag = foge[Symbol.toStringTag];
1514
var len = foge.byteLength;
15+
var species = SharedArrayBuffer[Symbol.species];

‎tests/baselines/reference/useSharedArrayBuffer4.symbols

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,23 @@ var bar = foge.slice(1, 10);
1111
>foge : Symbol(foge, Decl(useSharedArrayBuffer4.ts, 0, 3))
1212
>slice : Symbol(SharedArrayBuffer.slice, Decl(lib.es2017.sharedmemory.d.ts, --, --))
1313

14-
var species = foge[Symbol.species];
15-
>species : Symbol(species, Decl(useSharedArrayBuffer4.ts, 2, 3))
16-
>foge : Symbol(foge, Decl(useSharedArrayBuffer4.ts, 0, 3))
17-
>Symbol.species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
18-
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
19-
>species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
20-
2114
var stringTag = foge[Symbol.toStringTag];
22-
>stringTag : Symbol(stringTag, Decl(useSharedArrayBuffer4.ts, 3, 3))
15+
>stringTag : Symbol(stringTag, Decl(useSharedArrayBuffer4.ts, 2, 3))
2316
>foge : Symbol(foge, Decl(useSharedArrayBuffer4.ts, 0, 3))
2417
>Symbol.toStringTag : Symbol(SymbolConstructor.toStringTag, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
2518
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
2619
>toStringTag : Symbol(SymbolConstructor.toStringTag, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
2720

2821
var len = foge.byteLength;
29-
>len : Symbol(len, Decl(useSharedArrayBuffer4.ts, 4, 3))
22+
>len : Symbol(len, Decl(useSharedArrayBuffer4.ts, 3, 3))
3023
>foge.byteLength : Symbol(SharedArrayBuffer.byteLength, Decl(lib.es2017.sharedmemory.d.ts, --, --))
3124
>foge : Symbol(foge, Decl(useSharedArrayBuffer4.ts, 0, 3))
3225
>byteLength : Symbol(SharedArrayBuffer.byteLength, Decl(lib.es2017.sharedmemory.d.ts, --, --))
3326

27+
var species = SharedArrayBuffer[Symbol.species];
28+
>species : Symbol(species, Decl(useSharedArrayBuffer4.ts, 4, 3))
29+
>SharedArrayBuffer : Symbol(SharedArrayBuffer, Decl(lib.es2017.sharedmemory.d.ts, --, --), Decl(lib.es2017.sharedmemory.d.ts, --, --))
30+
>Symbol.species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
31+
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
32+
>species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
33+

‎tests/baselines/reference/useSharedArrayBuffer4.types

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,6 @@ var bar = foge.slice(1, 10);
2727
>10 : 10
2828
> : ^^
2929

30-
var species = foge[Symbol.species];
31-
>species : SharedArrayBuffer
32-
> : ^^^^^^^^^^^^^^^^^
33-
>foge[Symbol.species] : SharedArrayBuffer
34-
> : ^^^^^^^^^^^^^^^^^
35-
>foge : SharedArrayBuffer
36-
> : ^^^^^^^^^^^^^^^^^
37-
>Symbol.species : unique symbol
38-
> : ^^^^^^^^^^^^^
39-
>Symbol : SymbolConstructor
40-
> : ^^^^^^^^^^^^^^^^^
41-
>species : unique symbol
42-
> : ^^^^^^^^^^^^^
43-
4430
var stringTag = foge[Symbol.toStringTag];
4531
>stringTag : "SharedArrayBuffer"
4632
> : ^^^^^^^^^^^^^^^^^^^
@@ -65,3 +51,17 @@ var len = foge.byteLength;
6551
>byteLength : number
6652
> : ^^^^^^
6753

54+
var species = SharedArrayBuffer[Symbol.species];
55+
>species : SharedArrayBufferConstructor
56+
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
57+
>SharedArrayBuffer[Symbol.species] : SharedArrayBufferConstructor
58+
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
59+
>SharedArrayBuffer : SharedArrayBufferConstructor
60+
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
61+
>Symbol.species : unique symbol
62+
> : ^^^^^^^^^^^^^
63+
>Symbol : SymbolConstructor
64+
> : ^^^^^^^^^^^^^^^^^
65+
>species : unique symbol
66+
> : ^^^^^^^^^^^^^
67+

‎tests/baselines/reference/useSharedArrayBuffer5.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
//// [useSharedArrayBuffer5.ts]
44
var foge = new SharedArrayBuffer(1024);
5-
var species = foge[Symbol.species];
6-
var stringTag = foge[Symbol.toStringTag];
5+
var stringTag = foge[Symbol.toStringTag];
6+
var species = SharedArrayBuffer[Symbol.species];
77

88
//// [useSharedArrayBuffer5.js]
99
var foge = new SharedArrayBuffer(1024);
10-
var species = foge[Symbol.species];
1110
var stringTag = foge[Symbol.toStringTag];
11+
var species = SharedArrayBuffer[Symbol.species];

‎tests/baselines/reference/useSharedArrayBuffer5.symbols

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ var foge = new SharedArrayBuffer(1024);
55
>foge : Symbol(foge, Decl(useSharedArrayBuffer5.ts, 0, 3))
66
>SharedArrayBuffer : Symbol(SharedArrayBuffer, Decl(lib.es2017.sharedmemory.d.ts, --, --), Decl(lib.es2017.sharedmemory.d.ts, --, --))
77

8-
var species = foge[Symbol.species];
9-
>species : Symbol(species, Decl(useSharedArrayBuffer5.ts, 1, 3))
10-
>foge : Symbol(foge, Decl(useSharedArrayBuffer5.ts, 0, 3))
11-
>Symbol.species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
12-
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
13-
>species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
14-
158
var stringTag = foge[Symbol.toStringTag];
16-
>stringTag : Symbol(stringTag, Decl(useSharedArrayBuffer5.ts, 2, 3))
9+
>stringTag : Symbol(stringTag, Decl(useSharedArrayBuffer5.ts, 1, 3))
1710
>foge : Symbol(foge, Decl(useSharedArrayBuffer5.ts, 0, 3))
1811
>Symbol.toStringTag : Symbol(SymbolConstructor.toStringTag, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
1912
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
2013
>toStringTag : Symbol(SymbolConstructor.toStringTag, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
2114

15+
var species = SharedArrayBuffer[Symbol.species];
16+
>species : Symbol(species, Decl(useSharedArrayBuffer5.ts, 2, 3))
17+
>SharedArrayBuffer : Symbol(SharedArrayBuffer, Decl(lib.es2017.sharedmemory.d.ts, --, --), Decl(lib.es2017.sharedmemory.d.ts, --, --))
18+
>Symbol.species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
19+
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
20+
>species : Symbol(SymbolConstructor.species, Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
21+

‎tests/baselines/reference/useSharedArrayBuffer5.types

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,6 @@ var foge = new SharedArrayBuffer(1024);
1111
>1024 : 1024
1212
> : ^^^^
1313

14-
var species = foge[Symbol.species];
15-
>species : SharedArrayBuffer
16-
> : ^^^^^^^^^^^^^^^^^
17-
>foge[Symbol.species] : SharedArrayBuffer
18-
> : ^^^^^^^^^^^^^^^^^
19-
>foge : SharedArrayBuffer
20-
> : ^^^^^^^^^^^^^^^^^
21-
>Symbol.species : unique symbol
22-
> : ^^^^^^^^^^^^^
23-
>Symbol : SymbolConstructor
24-
> : ^^^^^^^^^^^^^^^^^
25-
>species : unique symbol
26-
> : ^^^^^^^^^^^^^
27-
2814
var stringTag = foge[Symbol.toStringTag];
2915
>stringTag : "SharedArrayBuffer"
3016
> : ^^^^^^^^^^^^^^^^^^^
@@ -39,3 +25,17 @@ var stringTag = foge[Symbol.toStringTag];
3925
>toStringTag : unique symbol
4026
> : ^^^^^^^^^^^^^
4127

28+
var species = SharedArrayBuffer[Symbol.species];
29+
>species : SharedArrayBufferConstructor
30+
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
31+
>SharedArrayBuffer[Symbol.species] : SharedArrayBufferConstructor
32+
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
33+
>SharedArrayBuffer : SharedArrayBufferConstructor
34+
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
35+
>Symbol.species : unique symbol
36+
> : ^^^^^^^^^^^^^
37+
>Symbol : SymbolConstructor
38+
> : ^^^^^^^^^^^^^^^^^
39+
>species : unique symbol
40+
> : ^^^^^^^^^^^^^
41+

‎tests/cases/conformance/es2017/useSharedArrayBuffer4.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33

44
var foge = new SharedArrayBuffer(1024);
55
var bar = foge.slice(1, 10);
6-
var species = foge[Symbol.species];
76
var stringTag = foge[Symbol.toStringTag];
8-
var len = foge.byteLength;
7+
var len = foge.byteLength;
8+
var species = SharedArrayBuffer[Symbol.species];

‎tests/cases/conformance/es2017/useSharedArrayBuffer5.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
// @lib: es6,es2017.sharedmemory
33

44
var foge = new SharedArrayBuffer(1024);
5-
var species = foge[Symbol.species];
6-
var stringTag = foge[Symbol.toStringTag];
5+
var stringTag = foge[Symbol.toStringTag];
6+
var species = SharedArrayBuffer[Symbol.species];

0 commit comments

Comments
 (0)