Skip to content

fix: diagnostic message for class name 'Object' when targeting different ECMAScript versions #61358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 60 commits into from
Closed

fix: diagnostic message for class name 'Object' when targeting different ECMAScript versions #61358

wants to merge 60 commits into from

Conversation

idango10
Copy link
Contributor

@idango10 idango10 commented Mar 5, 2025

Fixes: #61270

@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Mar 5, 2025
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Mar 5, 2025
idango10 and others added 25 commits March 5, 2025 23:19
@idango10
fix format issue
852d6f4
@csigs
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_…
1efdcd9 
…20250306202248269 to main (microsoft#61368)
@dependabot
Bump github/codeql-action from 3.28.10 to 3.28.11 in the github-actio…
0aac720 
…ns group (microsoft#61387)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dragomirtitian
Fix serialization of accessor types in declaration files. (microsoft#…
a00b324 
…61392)
@a-tarasyuk
fix(60908): Unexpected "'Type' is declared but its value is never rea…
ee3dd72 
…d." error with jsdoc @import syntax (microsoft#60921)
@DanielRosenwasser
Fix errors on type assertions in erasableSyntaxOnly (microsoft#61452)
4dc677b
@dependabot
Bump the github-actions group with 4 updates (microsoft#61474)
19b7772 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@frodi-karlsson
Fix lib.includes('dom') check in containerSeemsToBeEmptyDomElement (
29e6d66 
microsoft#61481)
@jakebailey @DanielRosenwasser
Add new release publisher yaml (microsoft#61491)
c7a559e 
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
@jakebailey
Fix incorrect name in new release pipeline (microsoft#61514)
7b26d2e
@Andarist
Fixed a symbol display crash on expando members write locations (micr…
89c572c 
…osoft#55478)
@dependabot
Bump github/codeql-action from 3.28.12 to 3.28.13 in the github-actio…
7205eda 
…ns group (microsoft#61509)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@zardoy @sandersn
Exclude completions of binding pattern variable initializers (microso…
ba663f6 
…ft#52723)

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@jakebailey
Convert release publishing inputs into parameters (microsoft#61523)
83dc0bb
@Andarist
Treat functions with @type tags on parameters as typed in JS files (m…
eef7c14 
…icrosoft#61177)
@gabritto
Expandable hover (microsoft#61492)
069de74
@andrewbranch
Fix crash when serializing default export in error (microsoft#61582)
6afd0fb
@eps1lon
Deemphasize old JSX transform (microsoft#61586)
0a1aa6d
@dependabot
Bump the github-actions group across 1 directory with 3 updates (micr…
62b172b 
…osoft#61601)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@HansBrende
Fix microsoft#61098 (microsoft#61113)
75202af
@mrazauskas
Add the .getNonPrimitiveType() method to the TypeChecker (microso…
38b78b7 
…ft#61562)
@a-tarasyuk
fix(61258): Renaming namespace with const enum doesn't update enum re…
11e7932 
…ferences (microsoft#61263)
@Zzzen @sandersn @jakebailey
arguments should not be allowed in class static block (microsoft#48172
e37ca49 
)

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
@Zzzen @sandersn
check usage before declaration for decorators (microsoft#50372)
5e36778 
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@Joseph-Martre @sandersn
docs(lib): add @throws JSDoc for JSON methods (microsoft#61596)
d88d3a4 
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
csigs and others added 18 commits June 4, 2025 12:51
@csigs
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_…
2b88aeb 
…20250604192236101 to main (microsoft#61815)
@a-tarasyuk
fix(61747): for (using of = is incorrectly parsed (microsoft#61764)
a591ca3
@magic-akari
fix(checker): report error when using bigint as enum key (microsoft#6…
ac03ba4 
…1777)
@RyanCavanaugh
tsc --init update (microsoft#61813)
cd34199
@nicolo-ribaudo @ryzokuken
Add support for import defer proposal (microsoft#60757)
a69c6d0 
Co-authored-by: Ujjwal Sharma <ryzokuken@disroot.org>
Co-authored-by: Nicolò Ribaudo <hell@nicr.dev>
@dirkluijk @jakebailey
feat: add Error.isError() to ESNext lib (microsoft#60788)
ffd98c1 
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
@Andarist
Cache mapper instantiations (microsoft#61505)
51dcd90
@Renegade334
Add lib.esnext.sharedmemory (microsoft#61646)
652ed7f
@Renegade334
explicitly disallow using in ambient contexts (microsoft#61781)
1e24945
@Andarist
Issue "'{0}' declarations can only be declared inside a block." for b…
fa2a0fc 
…lock-scoped variables in presence of parse errors (microsoft#61824)
@andrewbranch
Fix helpers emit for .cjs files in ESM module mode (microsoft#61814)
7715955
@Andarist
Avoid resolving source prop type when the target is unknown/any (m…
355b9e0 
…icrosoft#61660)
@VincentBailly
optimization, reduce memory usage (microsoft#61822)
97cfa26
@andrewbranch
Add --module node20 (microsoft#61805)
cb38d99
@ahejlsberg
Fix type variable leaks and cache inconsistencies (microsoft#61668)
34d1ea6
@nicolo-ribaudo
Restore import defer = parsing (microsoft#61837)
0dfd0c2
@jakebailey
Port "Improve type discrimination algorithm" from tsgo (microsoft#61828)
12e09f4
@AllenSH12
fix link to "Help Wanted" issues (microsoft#61843)
529ed09
jakebailey
jakebailey requested changes Jun 11, 2025
View reviewed changes
src/compiler/types.ts Outdated
@@ -7598,7 +7598,7 @@ export const enum ScriptKind {
// June of each year. This includes changes to `LanguageFeatureMinimumTarget`, `ScriptTarget`,
// `ScriptTargetFeatures` transformers/esnext.ts, compiler/commandLineParser.ts,
// compiler/utilitiesPublic.ts, and the contents of each lib/esnext.*.d.ts file.
export const enum ScriptTarget {
export enum ScriptTarget {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be changed.

src/compiler/checker.ts Outdated
error(
name,
Diagnostics.Class_name_cannot_be_Object_when_targeting_0_with_module_1,
ScriptTarget[languageVersion],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be using reverse mapping to find the names of language versions, as this depends on how the enum is defined and will break if two things alias each other. We should have some other standard way to print out target kinds like this.

I'd personally suggest just making the message say "ES5 and above".

@github-project-automation github-project-automation bot moved this from Not started to Waiting on author in PR Backlog Jun 11, 2025
@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update some generated declaration files related to the DOM. These files aren't meant to be edited by hand, as they are synchronized with files in the TypeScript-DOM-lib-generator repository. You can read more here. For house-keeping purposes, this pull request will be closed.

@github-project-automation github-project-automation bot moved this from Waiting on author to Done in PR Backlog Jun 11, 2025
@idango10
Copy link
Contributor Author

Sorry for the rebase flop 😅
I'll create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error "Class name cannot be 'Object' when targeting ES5 with module CommonJS." when not targeting es5