Skip to content

Make reflection step work with various openrouter models #6695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Philipp-Userlike
Copy link

Why are these changes needed?

This is an attempt to address #5621 and general issues with OpenAI compatible providers and the reflection step.
I had the issue reproduced with both claude and gemini openrouter models and confirmed they can use the reflection step now.
And I think using tool_choice=none is a good idea in general

Related issue number

#5621

Checks

@ekzhu
Copy link
Collaborator

ekzhu commented Jun 19, 2025

Can you confirm this works for OpenAI endpoint? I hope we can add a general argument tool_choice to the base class methods so all model clients can support it.

@ekzhu
Copy link
Collaborator

ekzhu commented Jun 19, 2025

@Philipp-Userlike see #6696

@ekzhu ekzhu mentioned this pull request Jun 20, 2025
3 tasks
@Philipp-Userlike
Copy link
Author

@ekzhu yes it also works with openai. I'm still clearing with my employer that I can agree to the policy, but I assume it will be fine.
The tool_choice general argument sounds good, I can adapt my PR to use that after it is done 👍

@Philipp-Userlike
Copy link
Author

@microsoft-github-policy-service agree [company="Userlike"]

@Philipp-Userlike
Copy link
Author

@microsoft-github-policy-service agree company="Userlike"

@ekzhu
Copy link
Collaborator

ekzhu commented Jun 30, 2025

See #6697 has already been merged. @Philipp-Userlike do you want to create a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants