-
Notifications
You must be signed in to change notification settings - Fork 580
[MEDIUM] Patch libvirt for CVE-2024-4418 #13811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
[MEDIUM] Patch libvirt for CVE-2024-4418 #13811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy build. Patch exactly matches with upstream reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the License Check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Buddy Build
- patch applied during the build (check
rpm.log
)Patch applies cleanly
- patch include an upstream reference
- PR has security tag
@Kanishk-Bansal I didn't quite get it, could you please throw some light, I don't see any license check failures. Thanks! |
352dbf6
to
d7f1101
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Waiting for @kgodara912 's review requested by @Kanishk-Bansal |
SPECS/libvirt/libvirt.spec
Outdated
@@ -1711,7 +1712,7 @@ exit 0 | |||
|
|||
%files docs | |||
%doc AUTHORS.rst NEWS.rst README.rst | |||
%doc libvirt-docs/* | |||
%license libvirt-docs/html/fonts/LICENSE.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not correct as it will remove all the docs from docs rpm (size reduced from 2MB to 100kb), we will see how to use exclude and packages to properly get license and docs both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait for a suggestion for a proper fix.
d7f1101
to
38a2ab4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the license issue seems non-trivial for now. Let's keep this PR moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
38a2ab4
to
f8476e8
Compare
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Addresses libvirt CVE-2024-4418
Patch file: https://gitlab.com/libvirt/libvirt/-/commit/8074d64dc2eca846d6a61efe1a9b7428a0ce1dd1
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology