Skip to content

[MEDIUM] Patch libvirt for CVE-2024-4418 #13811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

aninda-al
Copy link
Contributor

@aninda-al aninda-al commented May 16, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Addresses libvirt CVE-2024-4418
Patch file: https://gitlab.com/libvirt/libvirt/-/commit/8074d64dc2eca846d6a61efe1a9b7428a0ce1dd1

Change Log
Does this affect the toolchain?

NO

Associated issues
  • NA
Links to CVEs
Test Methodology
  • local build

@aninda-al aninda-al requested a review from a team as a code owner May 16, 2025 01:09
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels May 16, 2025
Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build. Patch exactly matches with upstream reference.

Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the License Check

@Kanishk-Bansal Kanishk-Bansal self-requested a review May 16, 2025 11:12
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Buddy Build
  • patch applied during the build (check rpm.log) Patch applies cleanly
  • patch include an upstream reference
  • PR has security tag

@aninda-al
Copy link
Contributor Author

Please fix the License Check

@Kanishk-Bansal I didn't quite get it, could you please throw some light, I don't see any license check failures. Thanks!

@Kanishk-Bansal Kanishk-Bansal force-pushed the v-anipradhan/libvirt/CVE-2024-4418 branch 2 times, most recently from 352dbf6 to d7f1101 Compare May 19, 2025 13:54
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kanishk-Bansal Kanishk-Bansal requested a review from kgodara912 May 21, 2025 08:40
@0xba1a
Copy link
Contributor

0xba1a commented May 23, 2025

Waiting for @kgodara912 's review requested by @Kanishk-Bansal

@@ -1711,7 +1712,7 @@ exit 0

%files docs
%doc AUTHORS.rst NEWS.rst README.rst
%doc libvirt-docs/*
%license libvirt-docs/html/fonts/LICENSE.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not correct as it will remove all the docs from docs rpm (size reduced from 2MB to 100kb), we will see how to use exclude and packages to properly get license and docs both.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for a suggestion for a proper fix.

@Kanishk-Bansal Kanishk-Bansal force-pushed the v-anipradhan/libvirt/CVE-2024-4418 branch from d7f1101 to 38a2ab4 Compare May 27, 2025 09:33
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the license issue seems non-trivial for now. Let's keep this PR moving forward.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aninda-al aninda-al force-pushed the v-anipradhan/libvirt/CVE-2024-4418 branch from 38a2ab4 to f8476e8 Compare May 29, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants