Skip to content

[Medium] patch rpm-ostree for CVE-2024-2905 #13818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

jykanase
Copy link
Contributor

@jykanase jykanase commented May 16, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

patch rpm-ostree for CVE-2024-2905

Change Log
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@jykanase jykanase requested a review from a team as a code owner May 16, 2025 10:34
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels May 16, 2025
Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build. Patch matches with upstream github pull request reference.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch matches with upstream reference. There is one issue was seen for few arm package installations as below, not sure if it is a real issue or just a transient glitch, this was previously also seen for few other packages.

clean up
+++ kill running container - e7401a969cbff96a8484f521444da02acee2982f0d899c20f0066e873aa2fcdb
Error response from daemon: Cannot kill container: e7401a969cbff96a8484f521444da02acee2982f0d899c20f0066e873aa2fcdb: container e7401a969cbff96a8484f521444da02acee2982f0d899c20f0066e873aa2fcdb is not running

@0xba1a
Copy link
Contributor

0xba1a commented May 20, 2025

The patch matches with upstream reference. There is one issue was seen for few arm package installations as below, not sure if it is a real issue or just a transient glitch, this was previously also seen for few other packages.

clean up
+++ kill running container - e7401a969cbff96a8484f521444da02acee2982f0d899c20f0066e873aa2fcdb
Error response from daemon: Cannot kill container: e7401a969cbff96a8484f521444da02acee2982f0d899c20f0066e873aa2fcdb: container e7401a969cbff96a8484f521444da02acee2982f0d899c20f0066e873aa2fcdb is not running

As this error has been seen previously also, considering this PR is not causing this failure.

@0xba1a 0xba1a merged commit 837e7d7 into microsoft:3.0-dev May 20, 2025
15 checks passed
@kgodara912
Copy link
Contributor

Adding notes for above failures: This patch is exclusive to x86_64 architecture hence the above failures in arm installation.

ExclusiveArch:  x86_64

https://github.com/microsoft/azurelinux/blob/3.0/SPECS/rpm-ostree/rpm-ostree.spec#L96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants