Skip to content

Fix circomlib symlink on windows #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

Fix circomlib symlink on windows #103

wants to merge 20 commits into from

Conversation

ljoy913
Copy link
Collaborator

@ljoy913 ljoy913 commented Mar 13, 2025

  • replace symlink with junction on Windows.
  • Windows requires elevated permissions to create symlinks from a git clone.
  • modified the run_setup.sh script to replace the symlink with a junction if the script determines circomlib is a file and not a directory.

ljoy913 added 20 commits February 27, 2025 13:29
@ljoy913
fix rand-core issue; fix type issue in verifier and client_helper;
b446257
@ljoy913
Remove cargo.lock from creds
204a343
@ljoy913
Delete Cargo.lock
f8364e2
@ljoy913
Make circom optional; add wasm feature; wasm showproof entry
c8d2e87
@ljoy913
Merge remote-tracking branch 'origin/fix_rand-core_build_errors' into…
ea28ac2 
… wasm-show-proof
@ljoy913
Merge remote-tracking branch 'origin' into wasm-show-proof
62bbef9
@ljoy913
Update client to build wasm at setup
85e0dc7
@ljoy913
Update sample setup
66da34c
@ljoy913
Update sample setup
de3fe0b
@ljoy913
Merge branch 'wasm-show-proof' of https://github.com/microsoft/cresce…
a24a5da 
…nt-credentials into wasm-show-proof
@ljoy913
Restored circuit_setup/circuits-mdl/circomlib from main
b07535f
@ljoy913
Fix progrss bar; fix mdl challenge param; fix missing proof_spec
0dce6c6
@ljoy913
add +x to client setup script
76a7212
@ljoy913
clean up cred toml
3d00b16
@ljoy913
Merge branch 'wasm-show-proof' of https://github.com/microsoft/cresce…
460eb82 
…nt-credentials into wasm-show-proof
@ljoy913
move wasm to own file; make seconds util function;
a2d6816
@ljoy913
rename js function; organize imports;
08832db
@ljoy913
Update firefox manifest for wasm
191bb41
@ljoy913
Merge branch 'main' of https://github.com/microsoft/crescent-credentials
e7bdf65 
 into wasm-show-proof
@ljoy913
Use junction instead of symlink for mdl circomlib on Windows;
e331914
@ljoy913
Copy link
Collaborator Author

ljoy913 commented Mar 13, 2025

Creating PR from new branch after switching from a previous branch somehow has preserved all the commits from the previous PR. Killing this PR and creating a fresh one from a clean clone.

@ljoy913 ljoy913 closed this Mar 13, 2025
@ljoy913 ljoy913 deleted the fix-mdl-symlink-on-windows branch March 13, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ljoy913