Skip to content

Updates samples to support selective disclosure #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 10, 2025
Merged

Updates samples to support selective disclosure #108

merged 15 commits into from
Apr 10, 2025

Conversation

christianpaquin
Copy link
Contributor

@christianpaquin christianpaquin commented Mar 28, 2025 •
edited
Loading

Sample now supports selective disclosure:

  • Created a new schema_UID: jwt_sd and a corresponding disclosure_uid: crescent://selective_disclosure
  • Updated issuer, client_helper, and verifier rocket servers
  • Added more options to the verifier's config for easy switch between email domain disclosure and selective disclosure for site 1
  • Updated browser extension

@christianpaquin christianpaquin mentioned this pull request Mar 28, 2025
Closed
christianpaquin and others added 14 commits March 31, 2025 13:48
@christianpaquin
Updated verfier site1 login page
1fa405b
@christianpaquin
Updated verifier to process the disclosed country claim
5c84ca7
@christianpaquin
Changed tenant country and scope to be per-user
4f3cf7e
@christianpaquin
replace base64url impl
7a61d70
@ljoy913
Update client for selective disclosure
8390dad
@christianpaquin
Add proof spec to site2
94354f4
@ljoy913
Add selective disclosure labels to popup disclosure cards
55b634f
@christianpaquin
fixed typo
cccf109
@christianpaquin
removed spurious entry in friendlyNames map
97c80b9
@christianpaquin
added reveal_domain_only to rs256-sd config (as expected in sample)
0367a2a
@christianpaquin
added user's language to verifier's page
e0db006
@christianpaquin
fix clippy recommendation for div_ceil
e812d45
@ljoy913
Fix issue where both mdl and jwt were offered incorrectly; fix verifi…
3a552d6 
…er setup to property copy public key; make sd attributes multi-line in ui; remove domain name from mdl import;
@ljoy913
map email to domain in client UI
6bc4697
@christianpaquin christianpaquin marked this pull request as ready for review April 9, 2025 13:44
@christianpaquin christianpaquin requested a review from ljoy913 April 9, 2025 13:44
@christianpaquin christianpaquin mentioned this pull request Apr 9, 2025
Merged
ljoy913
ljoy913 approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@ljoy913 ljoy913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@christianpaquin christianpaquin merged commit 52e5c80 into main Apr 10, 2025
4 checks passed
@christianpaquin christianpaquin deleted the integrate-sd-in-samples branch April 10, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoy913 ljoy913

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianpaquin @ljoy913