Skip to content

Use halo2curves for T256 implementation #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 21, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
@@ -75,6 +75,12 @@ jobs:
cd creds
../clippy_command.sh

- name: Run clippy for /ecdsa-pop
run: |
cd ecdsa-pop
../clippy_command.sh


- name: Run clippy for mdl-tools
run: |
cd circuit_setup/mdl-tools
18 changes: 18 additions & 0 deletions NOTICE.md
Original file line number Diff line number Diff line change
@@ -1868,3 +1868,21 @@ https://github.com/lurk-lab/neptune/blob/main/LICENSE-MIT
### Additional Attributions
None

---

### Component
halo2curves
https://github.com/privacy-scaling-explorations/halo2curves
Path: forks/halo2curves
Note: forked to support the T256 elliptic curve

### Open Source License/Copyright Notice
MIT
https://github.com/privacy-scaling-explorations/halo2curves/blob/b6fa078aa36d04d7eb654a1e2f823e3fdf971041/LICENSE-MIT

Apache
https://github.com/privacy-scaling-explorations/halo2curves/blob/b6fa078aa36d04d7eb654a1e2f823e3fdf971041/LICENSE-APACHE

### Additional Attributions
None

2 changes: 1 addition & 1 deletion circuit_setup/mdl-tools/src/bin/prepare-prover-input.rs
Original file line number Diff line number Diff line change
@@ -438,7 +438,7 @@ fn main() {
issuer_auth
.verify::<VerifyingKey, Signature>(&issuer_pub_key, None, None);
if !verification_result.is_success() {
panic!("Error: issuer signature verification failed");
panic!("Error: issuer signature verification failed: {}", verification_result.into_result().err().unwrap());
}

// process the signature
1 change: 1 addition & 0 deletions clippy_command.sh
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
# Invoke clippy with this command to allow some lints

RUSTFLAGS="--deny warnings" cargo clippy --release --tests -- \
--no-deps \
-A clippy::needless_range_loop \
-A clippy::same_item_push \
-A clippy::should_implement_trait \
5 changes: 5 additions & 0 deletions creds/Cargo.toml
Original file line number Diff line number Diff line change
@@ -62,6 +62,11 @@ ark-poly-commit = { path = "../forks/ark-poly-commit", default-features = false,
ecdsa-pop = {path="../ecdsa-pop"}
p256 = { version = "0.13.2", features = ["ecdsa", "pem"]}

# Enable wasm build for getrandom
[target.'cfg(target_arch = "wasm32")'.dependencies]
getrandom_03 = { package = "getrandom", version = "0.3", features = ["wasm_js"] }
getrandom_02 = { package = "getrandom", version = "0.2", features = ["js"] }

[dev-dependencies]
criterion = { version = "0.5", features = ["html_reports"] }
serial_test = "*"
4 changes: 2 additions & 2 deletions creds/src/wasm_lib.rs
Original file line number Diff line number Diff line change
@@ -90,8 +90,8 @@ pub fn create_show_proof_wasm(
age.expect("Age not valid."),
)
} else {
proof_spec.presentation_message = Some(challenge);
create_show_proof(&mut client_state, &range_pk, &io_locations, &proof_spec).unwrap()
proof_spec.presentation_message = Some(challenge.into());
create_show_proof(&mut client_state, &range_pk, &io_locations, &proof_spec, None).unwrap()
};

let show_proof_b64 = write_to_b64url(&show_proof);
Loading
Oops, something went wrong.