Fix windows install issues #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ljoy913
commented
May 13, 2025
ljoy913
commented
- Fix x509 generation script
- Fix broken symlink in setup script
- Apply color-eyre fix from PR 117
| # generate self-signed root CA cert | ||
| openssl req -x509 -new -newkey ec:<(openssl ecparam -name secp521r1) -keyout "$tmpdir/root_CA.key" -out "$tmpdir/root_CA.crt" -nodes -subj "/CN=NY DMV Test Root CA" -days 3650 -config openssl_ca.cnf -extensions v3_ca -sha512 | ||
| openssl ecparam -name secp521r1 -out tmpkey.pem |
There was a problem hiding this comment.
Can you rename tmpkey.pem $tmpdir/ecparamp521?
|
|
||
| # generate intermediate CA cert request | ||
| openssl req -new -newkey ec:<(openssl ecparam -name secp384r1) -keyout "$tmpdir/CA.key" -out "$tmpdir/CA.csr" -nodes -subj "/CN=NY DMV Test CA" -config openssl_ca.cnf -extensions v3_ca -sha384 | ||
| openssl ecparam -name secp384r1 -out tmpkey.pem |
There was a problem hiding this comment.
Can you rename tmpkey.pem $tmpdir/ecparamp384?
|
|
||
| # root CA signs the CA cert request | ||
| openssl x509 -req -in "$tmpdir/CA.csr" -out "$tmpdir/CA.crt" -CA "$tmpdir/root_CA.crt" -CAkey "$tmpdir/root_CA.key" -CAcreateserial -days 1825 -extfile openssl_ca.cnf -extensions v3_ca -sha512 | ||
|
|
||
| # generate signer cert request | ||
| openssl req -new -newkey ec:<(openssl ecparam -name prime256v1) -keyout "$tmpdir/issuer.key" -out "$tmpdir/issuer.csr" -nodes -subj "/CN=NY DMV Test Issuer" -config openssl_ca.cnf -extensions v3_signer -sha256 | ||
| openssl ecparam -name prime256v1 -out tmpkey.pem |
There was a problem hiding this comment.
Can you rename tmpkey.pem $tmpdir/ecparamp256?
| @@ -58,7 +58,7 @@ if [ -f "${CIRCOM_SRC_DIR}/circomlib" ]; then | |||
| rm -f "${CIRCOM_SRC_DIR}/circomlib" | |||
| if [[ "$OS" == "Windows_NT" || "$(uname -o 2>/dev/null)" == "Msys" ]]; then | |||
| echo "Creating Windows junction..." | |||
| cmd //c "mklink /J ${CIRCOM_SRC_DIR//\//\\}\\circomlib circuits\\circomlib" | |||
| cmd //c "mklink /J $(cygpath -wa "$CIRCOM_SRC_DIR"/circomlib) $(cygpath -wa "${ROOT_DIR}/circuits/circomlib")" | |||
There was a problem hiding this comment.
Is cygpath always defined, even if you don't use a cygwin type system?
There was a problem hiding this comment.
Is cygpath always defined, even if you don't use a cygwin type system?
cygpath will only be used on windows/msys (gitbash) shells. If on ubuntu, the symlink will already be there and cygpath won't get called.
zaverucha
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.