-
Notifications
You must be signed in to change notification settings - Fork 433
[dev-v5] Add DataGrid - part 2, get base code working #3915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add doc start - Add Paginator / PaginationState
…/dev-v5/datagrid-part2
- Remove ::deep - Change county codes to align with v4
…com/microsoft/fluentui-blazor into users/vnbaaij/dev-v5/datagrid-part1
- Remove ::deep - Change county codes to align with v4 - Merge part 1 - Fix analyzer errors and warnings - Rename parameters
With this coming in, I'm so eager to try and migrate to v5 <3 |
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
…com/microsoft/fluentui-blazor into users/vnbaaij/dev-v5/datagrid-part2
- Fix error with flags - Fix css colors - Add tests
- Fix ToDo items - Misc code changes
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.7%
|
- Add more tests
dvoituron
requested changes
Jul 2, 2025
...ples/Demo/FluentUI.Demo.Client/Documentation/GetStarted/Migration/MigrationFluentDataGrid.md
Outdated
Show resolved
Hide resolved
- Add and use DataGridCellAlignment enum - Use overriden DisposeAsync - Use correct comment format
dvoituron
requested changes
Jul 2, 2025
- Use local variables in testing cell/row
…com/microsoft/fluentui-blazor into users/vnbaaij/dev-v5/datagrid-part2
dvoituron
requested changes
Jul 2, 2025
src/Core/Components/DataGrid/Infrastructure/ColumnsCollectedNotifier.cs
Outdated
Show resolved
Hide resolved
src/Core/Components/DataGrid/Infrastructure/IAsyncQueryExecutor.cs
Outdated
Show resolved
Hide resolved
- Implement SelectColumn localization - Fix CSS issue with select column
dvoituron
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.