Harshit 54/bugfix #1938
Open
Harshit 54/bugfix #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Created an issue as well for the fix - #1936 |
|
@microsoft-github-policy-service agree company="Colrows" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
max_length was not passed in the prompt template reduce_system_prompt in Global search.py
this throws an error.
[Provide a brief description of the changes made in this pull request.]
Related Issues
Global search has error
[Reference any related issues or tasks that this pull request addresses.]
Proposed Changes
added max_length in the parameter of _reduce_response. _stream_reduce_response already has this param.
[List the specific changes made in this pull request.]
Checklist
Additional Notes
[Add any additional notes or context that may be helpful for the reviewer(s).]