Logging SetLogCallback + Debugging cleanup #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SetLogCallback to enable runtime arbitrary log redirection Add Python bindings for og.set_log_callback Add python test for og.set_log_callback
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
edgchen1
reviewed
May 12, 2025
…into ryanunderhill/logging_improvements
baijumeswani
reviewed
Jun 6, 2025
baijumeswani
reviewed
Jun 6, 2025
edgchen1
reviewed
Jun 6, 2025
edgchen1
previously approved these changes
Jun 6, 2025
edgchen1
reviewed
Jun 10, 2025
edgchen1
reviewed
Jun 10, 2025
edgchen1
previously approved these changes
Jun 10, 2025
…into ryanunderhill/logging_improvements
…om/microsoft/onnxruntime-genai into ryanunderhill/logging_improvements
edgchen1
approved these changes
Jun 11, 2025
|
Thank you for the review. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate SizeOf in utils.cpp in favor of existing Ort::SizeOf. These were exact duplicates, I just forgot to remove one in the past somehow.
Add SetLogCallback to enable runtime arbitrary log redirection Add Python bindings for og.set_log_callback
Add python test for og.set_log_callback