openhcl_boot: add sidecar command line options #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `OPENHCL_SIDECAR` boot loader command-line option for controlling whether sidecar gets enabled: * `OPENHCL_SIDECAR=off`: Disable sidecar support. * `OPENHCL_SIDECAR=on`: Enable sidecar support, if possible. * `OPENHCL_SIDECAR=log`: Enable sidecar logging. This replaces the existing `SIDECAR_LOGGING` command line option.
chris-oo
reviewed
May 12, 2025
| /// Parse arguments from a command line. | ||
| pub fn parse(&mut self, cmdline: &str) { | ||
| for arg in cmdline.split_whitespace() { | ||
| if arg.starts_with(BOOT_LOG) { |
There was a problem hiding this comment.
hm this is kind of getting unwieldy - I wonder could we do anything better? can't think of anything offhand.
chris-oo
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
OPENHCL_SIDECARboot loader command-line option for controlling whether sidecar gets enabled:OPENHCL_SIDECAR=off: Disable sidecar support.OPENHCL_SIDECAR=on: Enable sidecar support, if possible.OPENHCL_SIDECAR=log: Enable sidecar logging.This replaces the existing
SIDECAR_LOGGINGcommand line option.