Skip to content

CVM Guest VSM: refactor the shared/encrypted bitmaps to be partition-wide #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sluck-msft
Copy link
Contributor

In preparation for VTL 1 memory support for CVMs, make the shared/encrypted bitmap tracking available on a partition-level, rather than in the GuestMemoryMapping (which ends up being per-VTL). Also includes some refactoring to isolate out the bitmap logic so that it can be reused for vtl protection bitmaps.

Tested: SNP +/- guest vsm boots

@sluck-msft sluck-msft force-pushed the gvsm/partition-wide-visibility-tracking branch from 7649ac4 to 1ae1a22 Compare May 20, 2025 22:20
@sluck-msft sluck-msft added the backport_2505 Change should be backported to the release/2505 branch label May 24, 2025
Copy link
Member

@jstarks jstarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally this seems reasonable. Some minor cleanup requests on the builder pattern.

smalis-msft
smalis-msft previously approved these changes May 30, 2025
@sluck-msft sluck-msft force-pushed the gvsm/partition-wide-visibility-tracking branch from c898724 to 2874f54 Compare June 2, 2025 17:39
Copy link

github-actions bot commented Jun 2, 2025

@sluck-msft sluck-msft enabled auto-merge (squash) June 2, 2025 18:55
@sluck-msft sluck-msft merged commit 1f14745 into microsoft:main Jun 2, 2025
48 of 50 checks passed
sluck-msft added a commit to sluck-msft/openvmm that referenced this pull request Jun 4, 2025
…wide (microsoft#1370)

In preparation for VTL 1 memory support for CVMs, make the
shared/encrypted bitmap tracking available on a partition-level, rather
than in the GuestMemoryMapping (which ends up being per-VTL). Also
includes some refactoring to isolate out the bitmap logic so that it can
be reused for vtl protection bitmaps.

Tested: SNP +/- guest vsm boots
sluck-msft added a commit to sluck-msft/openvmm that referenced this pull request Jun 4, 2025
…wide (microsoft#1370)

In preparation for VTL 1 memory support for CVMs, make the
shared/encrypted bitmap tracking available on a partition-level, rather
than in the GuestMemoryMapping (which ends up being per-VTL). Also
includes some refactoring to isolate out the bitmap logic so that it can
be reused for vtl protection bitmaps.

Tested: SNP +/- guest vsm boots
sluck-msft added a commit to sluck-msft/openvmm that referenced this pull request Jun 5, 2025
…wide (microsoft#1370)

In preparation for VTL 1 memory support for CVMs, make the
shared/encrypted bitmap tracking available on a partition-level, rather
than in the GuestMemoryMapping (which ends up being per-VTL). Also
includes some refactoring to isolate out the bitmap logic so that it can
be reused for vtl protection bitmaps.

Tested: SNP +/- guest vsm boots
benhillis pushed a commit that referenced this pull request Jun 5, 2025
…1474)

…wide (#1370)

In preparation for VTL 1 memory support for CVMs, make the
shared/encrypted bitmap tracking available on a partition-level, rather
than in the GuestMemoryMapping (which ends up being per-VTL). Also
includes some refactoring to isolate out the bitmap logic so that it can
be reused for vtl protection bitmaps.

Tested: SNP +/- guest vsm boots
@benhillis benhillis removed the backport_2505 Change should be backported to the release/2505 branch label Jun 5, 2025
@benhillis benhillis added the backported_2505 PR that has been backported to release/2505 label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport_2505_approved backported_2505 PR that has been backported to release/2505
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants