[Bug]: UI Mode collects 'git diff' for prompt only at launch time

[mxschmitt]

Version

ToT

Steps to reproduce

1. Start UI Mode
2. Run a failing test
3. Copy the Prompt
4. Assert: Ensure that the Git diff is the same as your local git diff
5. Make more local changes
6. Run the failing test
7. Assert: Ensure that the Git diff is the new updated local git diff

Expected behavior

Git diff gets updated and does not only get calculated at launch time of UI Mode.

Actual behavior

Its the old one.

Additional context

It gets calculated once at npx playwright test --ui time.

Environment

N/A

[Skn0tt]

The root of the problem seems to be that we take the git diff at plugin setup time, which is executed as part of global setup in the test server. I haven't tried it out, but it seems that moving the git diff operation from setup into begin is a good fix.

Copilot, could you please implement this for me? Here's where you need to update the plugin:

playwright/packages/playwright/src/plugins/gitCommitInfoPlugin.ts

Line 43 in cee8fb2

const gitCommitInfoPlugin = (fullConfig: FullConfigInternal): TestRunnerPlugin => {

And please make sure to write a reproduction test based on Max's steps above. Put the test next to

playwright/tests/playwright-test/ui-mode-trace.spec.ts

Line 557 in cee8fb2

test('should show copy prompt button in errors tab', async ({ runUITest }) => {

.

[Skn0tt]

closing as per #36014 (comment)