"Open windows from a previous session" opens wrong tabs after crash

[sparrowt]

Windows Terminal version

1.22.10731.0

Windows build number

10.0.26100.0

Other Software

No response

Steps to reproduce

1. Run Windows Terminal for several days, over which period many tabs have been opened, closed, renamed etc.
2. Somehow Windows Terminal crashes (this in itself is obviously caused by a different bug, but inevitably this will sometimes happen)
3. Re-launch Windows Terminal and find that it has restored the wrong tabs (the ones that were open last time it had a clean shutdown)

Expected Behavior

Windows Terminal should restore the tabs that were open at least vaguely recently before the crash (e.g. by persisting this state either on a regular interval, or each time a new tab is opened/renamed.

Actual Behavior

Instead it restores whatever tabs were open last time I explicitly closed it (i.e. the same set that it restored last time) which may well be multiple days ago and completely different from the tabs that I had been using before the crash.

Unfortunately this makes the restore feature pretty useless in the case of a crash 😢

[DHowett]

Hmmmmmmm. Well, that's not good. Thanks!

[DHowett]

Notes from discussion: maybe we should persist the window layout (cheap) every couple minutes or whatever, but not the buffers yet (too expensive to do serially).

Right now, we only clear the old session off disk when we save a new one. You can well imagine what that means. 🙂

[sparrowt]

maybe we should persist the window layout (cheap) every couple minutes or whatever, but not the buffers yet

Thanks yes that would be great - the crucial thing is remembering which set of things I was keeping an eye on and the terminal type + tab title (+ cwd) is much better than nothing. I'm not fussed about the buffers (in fact would be nice to be able to disable that, pretty sure I've seen another ticket for that).