wpf: allow OSC 52 to write the clipboard #18905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1043,7 +1048,7 @@ | |||
| // - text - selected text in plain-text format | |||
| // - htmlData - selected text in HTML format | |||
| // - rtfData - selected text in RTF format | |||
| HRESULT HwndTerminal::_CopyTextToSystemClipboard(const std::wstring& text, const std::string& htmlData, const std::string& rtfData) const | |||
| HRESULT HwndTerminal::_CopyTextToSystemClipboard(wil::zwstring_view text, wil::zstring_view htmlData, wil::zstring_view rtfData) const | |||
Check failure
Code scanning / check-spelling
Unrecognized Spelling
| @@ -1043,7 +1048,7 @@ | |||
| // - text - selected text in plain-text format | |||
| // - htmlData - selected text in HTML format | |||
| // - rtfData - selected text in RTF format | |||
| HRESULT HwndTerminal::_CopyTextToSystemClipboard(const std::wstring& text, const std::string& htmlData, const std::string& rtfData) const | |||
| HRESULT HwndTerminal::_CopyTextToSystemClipboard(wil::zwstring_view text, wil::zstring_view htmlData, wil::zstring_view rtfData) const | |||
Check failure
Code scanning / check-spelling
Unrecognized Spelling
| @@ -1099,7 +1104,7 @@ | |||
| // Arguments: | |||
| // - stringToCopy - The string to copy | |||
| // - lpszFormat - the name of the format | |||
| HRESULT HwndTerminal::_CopyToSystemClipboard(const std::string& stringToCopy, LPCWSTR lpszFormat) const | |||
| HRESULT HwndTerminal::_CopyToSystemClipboard(wil::zstring_view stringToCopy, LPCWSTR lpszFormat) const | |||
Check failure
Code scanning / check-spelling
Unrecognized Spelling
| @@ -145,8 +145,8 @@ | |||
|
|
|||
| void _UpdateFont(int newDpi); | |||
| void _WriteTextToConnection(const std::wstring_view text) noexcept; | |||
| HRESULT _CopyTextToSystemClipboard(const std::wstring& text, const std::string& htmlData, const std::string& rtfData) const; | |||
| HRESULT _CopyToSystemClipboard(const std::string& stringToCopy, LPCWSTR lpszFormat) const; | |||
| HRESULT _CopyTextToSystemClipboard(wil::zwstring_view text, wil::zstring_view htmlData, wil::zstring_view rtfData) const; | |||
Check failure
Code scanning / check-spelling
Unrecognized Spelling
| @@ -145,8 +145,8 @@ | |||
|
|
|||
| void _UpdateFont(int newDpi); | |||
| void _WriteTextToConnection(const std::wstring_view text) noexcept; | |||
| HRESULT _CopyTextToSystemClipboard(const std::wstring& text, const std::string& htmlData, const std::string& rtfData) const; | |||
| HRESULT _CopyToSystemClipboard(const std::string& stringToCopy, LPCWSTR lpszFormat) const; | |||
| HRESULT _CopyTextToSystemClipboard(wil::zwstring_view text, wil::zstring_view htmlData, wil::zstring_view rtfData) const; | |||
Check failure
Code scanning / check-spelling
Unrecognized Spelling
lhecker
approved these changes
May 13, 2025
javierdlg
approved these changes
May 13, 2025
DHowett
added a commit
that referenced
this pull request
May 13, 2025
We never hooked up this callback! This allows a CLI application to emit text directly to the clipboard. (cherry picked from commit c64a9d2) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgaWn6c Service-Version: 1.23
DHowett
added a commit
that referenced
this pull request
May 13, 2025
We never hooked up this callback! This allows a CLI application to emit text directly to the clipboard. (cherry picked from commit c64a9d2) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgaWn6g Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never hooked up this callback!
This allows a CLI application to emit text directly to the clipboard.