VSTestBridge: Handle TestPropertyAttributes.Trait instead of special casing specific properties #5644
+26
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…casing specific properties
Youssef1313
commented
May 26, 2025
src/Platform/Microsoft.Testing.Extensions.VSTestBridge/ObjectModel/ObjectModelConverters.cs
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5644 +/- ##
==========================================
- Coverage 76.34% 76.29% -0.06%
==========================================
Files 602 602
Lines 36758 36754 -4
==========================================
- Hits 28063 28041 -22
- Misses 8695 8713 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/backport to rel/3.9 |
|
Started backporting to rel/3.9: https://github.com/microsoft/testfx/actions/runs/15270580401 |
nohwnd
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5642
Instead of special casing
MSTestDiscoverer.TestCategoryandTestObject.Traits, we instead useTestPropertyAttributes.Traitto determine whether a property is a trait.When the property value is
string[], we assume it's the "categories". Otherwise, we expect it to beKVP<string, string>[]which is a list of traits as key value pairs.NOTE: NUnit needs this. See nunit/nunit3-vs-adapter#1258