Skip to content

re-select "set as workspace env" does nothing #58

@eleanorjboyd

Description

@eleanorjboyd
Member

Testing #24503

  1. select venv as the workspace venv already
  2. click "set as workspace env"
  3. 🐛 nothing seems to happen because I am selecting the environment that was already selected
    ideas:
  • grey out that option
  • show notif that it was already selected

Image

Activity

karthiknadig

karthiknadig commented on Dec 7, 2024

@karthiknadig
Member

@cwebster-99 @luabud I need some input here. The issue here is that we want to show the ✔️ to select for multi-project scenarios. Suppose you have two environments, and two projects, and each one is selected for each project. Then the ✔️ is necessary as you might want to select the same environment for both projects. E.g, env1 -> project1, env2-> project2, user might want to select env1 -> project1, project2. By removing ✔️it makes it harder to select it.

But I also see the confusion that people can have with clicking the ✔️ on the selected environment.

cwebster-99

cwebster-99 commented on Dec 9, 2024

@cwebster-99
Member

Discussed offline and decided to surface a notification communicating that the environment has already been selected in the following scenario

  • User has one folder/project open
  • User tries to select the same environment that is already selected
added this to the January 2025 milestone on Dec 16, 2024
added
bugIssue identified by VS Code Team member as probable bug
on Dec 16, 2024
removed this from the January 2025 milestone on Jan 27, 2025
added this to the May 2025 milestone on May 30, 2025

2 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priorityverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

Projects

No projects

Participants

@karthiknadig@eleanorjboyd@cwebster-99@anthonykim1

Issue actions

    re-select "set as workspace env" does nothing · Issue #58 · microsoft/vscode-python-environments