Why do we have `src/vs/editor/common/codecs` in editor?

[bpasero]

I always thought that vs/editor is reserved for code that belongs to the monaco standalone editor. It seems to me src/vs/editor/common/codecs is only used in workbench/contrib/chat and as such should either live there or in a base component?

//cc @hediet @alexdima

[legomushroom]

As I recall, I've added these in my first PR and initially they were in the /workbench layer. During the PR review I've got feedback that these should be moved to a "more reusable place", which I interpreted as "up the layers". The reason I stopped because this is where the IRange interface is defined, so could not go any further 😄

Nothing at the /editor layer uses these, and the only backward dependency is the IRange interface, so it will be a trivial task to move it back to the /workbench/contrib/chat.

[bpasero]

@legomushroom if this is only used in contrib/chat, then yes it should be living in contrib/chat. If more components end up using it, I would think platform or base. One challenge is that a type defined in editor cannot be used in base or platform.

[legomushroom]

Waiting for the debt week to address this issue since existing dev branches contain changes on top of the files. It should be a quick and easy 5 minute change at that point.