Use ResourceSet/ResourceMap when mapping URIs

[aeschli]

vscode/src/vs/workbench/contrib/chat/common/promptSyntax/parsers/basePromptParser.ts

Line 253 in 714d186

if (seenReferences.includes(this.uri.path)) {

Uses this.uri.path to identify URIs that have already been processed.

Use ResourceSet/ResourceMap instead to work with the full URI.

Note: seenReferences.push(this.uri.path); seems unnecessary

[legomushroom]

@aeschli so the issue here is that the path does not fully identify the prompt? I think the initial assumption was because we support only file prompts, it is ok. Now I know that the schema matters even for the "files", so it works as expected in the remote/virtual workspace scenarios 🤔

Note: seenReferences.push(this.uri.path); seems unnecessary

Nope, that is on purpose - the list of paths is used by the "recursive reference" error, and the last push make the paths to loop, as you'd expect.

[bpasero]

@legomushroom we have collection helpers for when your key is Uri also known as ResourceSet/ResourceMap. You should be using them when dealing with Uri instead of using the path or fsPath property.

vscode/src/vs/base/common/map.ts

Line 153 in 6a02f55

export class ResourceSet implements Set<URI> {

vscode/src/vs/base/common/map.ts

Line 48 in 6a02f55

export class ResourceMap<T> implements Map<URI, T> {

Similarly we have lots of methods to compare Uri or work with them, all here:

vscode/src/vs/base/common/resources.ts

Lines 360 to 375 in 6a02f55

	export const isEqual = extUri.isEqual.bind(extUri);
	export const isEqualOrParent = extUri.isEqualOrParent.bind(extUri);
	export const getComparisonKey = extUri.getComparisonKey.bind(extUri);
	export const basenameOrAuthority = extUri.basenameOrAuthority.bind(extUri);
	export const basename = extUri.basename.bind(extUri);
	export const extname = extUri.extname.bind(extUri);
	export const dirname = extUri.dirname.bind(extUri);
	export const joinPath = extUri.joinPath.bind(extUri);
	export const normalizePath = extUri.normalizePath.bind(extUri);
	export const relativePath = extUri.relativePath.bind(extUri);
	export const resolvePath = extUri.resolvePath.bind(extUri);
	export const isAbsolutePath = extUri.isAbsolutePath.bind(extUri);
	export const isEqualAuthority = extUri.isEqualAuthority.bind(extUri);
	export const hasTrailingPathSeparator = extUri.hasTrailingPathSeparator.bind(extUri);
	export const removeTrailingPathSeparator = extUri.removeTrailingPathSeparator.bind(extUri);
	export const addTrailingPathSeparator = extUri.addTrailingPathSeparator.bind(extUri);

[legomushroom]

@bpasero yeah I already do in some parts of the code, I think this issue is for this specific use case 🤔 Tracking this as a bug moving on because of the issue that the path does not identify prompts in all possible use cases.

[legomushroom]

One more case in #246573

[aeschli]

Will be fixed by #251235