Skip to content

Make public api and tests the same for all TFMs #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2025

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented Jun 9, 2025

Changes:

  • Make public api and tests the same for all TFMs
  • Run the same set of tests for all platforms
  • Update System.Threading.Tasks.Extensions dependency
  • Hotfix release_packages.yml

Motivation:
Some public api is not available for for .NET Standard in current implementation.
Problem is that ValueTask is a core type in modern dotnet ecosystem. A lot of popular libraries using it.
Make sense to remove this gap and make public api the same for all platforms

Why System.Threading.Tasks.Extensions was updated?
Old version doesn't have non-generic ValueTask type

@Romfos Romfos requested a review from dtchepak June 9, 2025 05:10
@Romfos Romfos mentioned this pull request May 30, 2025
21 tasks
@Romfos Romfos marked this pull request as ready for review June 9, 2025 05:12
@Romfos Romfos merged commit d9e759f into nsubstitute:main Jul 13, 2025
8 checks passed
@Romfos Romfos deleted the public-api-unification branch July 13, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants