Skip to content

ITEP-70721: Add BDD test for label reordering #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

JortBergfeld
Copy link
Contributor

@JortBergfeld JortBergfeld commented Jul 9, 2025

πŸ“ Description

Add a BDD test for label reordering

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • πŸš€ New feature – Non-breaking change which adds functionality
  • πŸ”¨ Refactor – Non-breaking change which refactors the code base
  • πŸ’₯ Breaking change – Changes that break existing functionality
  • πŸ“š Documentation update
  • πŸ”’ Security update
  • πŸ§ͺ Tests

πŸ§ͺ Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • βœ… Tested manually
  • πŸ€– Run automated end-to-end tests

βœ… Checklist

Before submitting the PR, ensure the following:

  • πŸ” PR title is clear and descriptive
  • πŸ“ For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • πŸ’¬ I have commented my code, especially in hard-to-understand areas
  • πŸ“„ I have made corresponding changes to the documentation
  • βœ… I have added tests that prove my fix is effective or my feature works

@JortBergfeld JortBergfeld self-assigned this Jul 9, 2025
@Copilot Copilot AI review requested due to automatic review settings July 9, 2025 07:13
@JortBergfeld JortBergfeld requested a review from a team as a code owner July 9, 2025 07:13
@github-actions github-actions bot added the IAI Interactive AI backend label Jul 9, 2025
Copilot

This comment was marked as outdated.

@JortBergfeld JortBergfeld force-pushed the jort/ITEP-70721-label_reordering_bdd branch from 3cf34a5 to 9988cc6 Compare July 9, 2025 09:21
@JortBergfeld JortBergfeld force-pushed the jort/ITEP-70721-label_reordering_bdd branch from 3787ef0 to 9e4155d Compare July 10, 2025 12:31
@JortBergfeld JortBergfeld requested a review from Copilot July 10, 2025 14:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a BDD test feature for label reordering functionality across different project types. The test verifies that users can reorder labels in projects and that the labels maintain their new order after the operation.

Key changes:

  • Implements label reordering step definitions with API integration
  • Adds a new feature file to test label reordering across multiple project types
  • Introduces helper functions for ordered label retrieval and verification

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
interactive_ai/tests/e2e/features/steps/label_management.py Adds helper functions and step definitions for label reordering operations and order verification
interactive_ai/tests/e2e/features/label_reordering.feature Defines BDD scenarios for testing label reordering across different project types
Comments suppressed due to low confidence (1)

interactive_ai/tests/e2e/features/steps/label_management.py:222

  • [nitpick] The parameter name 'raw_label_names' is inconsistent with the function name which suggests it handles reordering. Consider renaming to 'ordered_label_names' to better reflect its purpose.
def step_when_user_reorders_labels(context: Context, raw_label_names: str):

@JortBergfeld JortBergfeld added this pull request to the merge queue Jul 11, 2025
Merged via the queue into main with commit 0c54776 Jul 11, 2025
13 checks passed
@JortBergfeld JortBergfeld deleted the jort/ITEP-70721-label_reordering_bdd branch July 11, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IAI Interactive AI backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants