-
Notifications
You must be signed in to change notification settings - Fork 544
feat: Add Clone implementation to SdkLogger for consistency with SdkTracer #3059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clone
implementations for SdkLogger
/ SdkTracer
Copilot finished work on behalf of
lalitb
July 7, 2025 18:59
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
=======================================
- Coverage 80.2% 80.1% -0.1%
=======================================
Files 126 126
Lines 21949 21949
=======================================
- Hits 17604 17603 -1
- Misses 4345 4346 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@copilot run cargo fmt and other lint tools |
Copilot finished work on behalf of
cijothomas
July 10, 2025 00:23
4 tasks
cijothomas
reviewed
Jul 16, 2025
0105bb6
to
24f2c99
Compare
lalitb
approved these changes
Jul 16, 2025
Oops! Pushed to wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an API inconsistency where
SdkTracer
implementsClone
butSdkLogger
does not, requiring users to wrapSdkLogger
inArc
for cloning scenarios.Changes Made
Clone
to the derive macro forSdkLogger
structWhy This Change is Safe
Both
SdkLogger
andSdkTracer
have identical structure:scope: InstrumentationScope
(already implementsClone
)provider: SdkLoggerProvider
/SdkTracerProvider
(both already implementClone
)Since all fields already implement
Clone
, adding it toSdkLogger
is a straightforward and safe change.Example Usage
This makes the logging and tracing APIs consistent and reduces the need for
Arc
wrappers when cloning is required.Fixes #3058.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.