Remove upper bound on puppet-strings #3391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generating documentation still works. $ bundle exec rake docs:all
[warn]: The function definition for '[]' near bolt-modules/boltlib/lib/puppet/datatypes/resultset.rb:37 is not a Callable type
[warn]: Missing @param tag for attribute 'report' near bolt-modules/boltlib/lib/puppet/datatypes/applyresult.rb:38.
[warn]: Missing @param tag for attribute 'target' near bolt-modules/boltlib/lib/puppet/datatypes/applyresult.rb:38.
[warn]: Missing @param tag for attribute 'error' near bolt-modules/boltlib/lib/puppet/datatypes/applyresult.rb:38.
[warn]: Missing @param tag for attribute 'catalog' near bolt-modules/boltlib/lib/puppet/datatypes/applyresult.rb:38.
Files 62
Modules 0 (0 undocumented)
Classes 1 (1 undocumented)
Constants 0 (0 undocumented)
Attributes 0 (0 undocumented)
Methods 83 (0 undocumented)
Puppet Classes 0 (0 undocumented)
Puppet Data Types 7 (0 undocumented)
Puppet Data Type Aliases 0 (0 undocumented)
Puppet Defined Types 0 (0 undocumented)
Puppet Types 0 (0 undocumented)
Puppet Providers 0 (0 undocumented)
Puppet Functions 54 (0 undocumented)
Puppet Tasks 0 (0 undocumented)
Puppet Plans 0 (0 undocumented)
99.31% documented
Generated function reference at:
/Users/gh/git/bolt/documentation/plan_functions.md
Generated data type reference at:
/Users/gh/git/bolt/documentation/bolt_types_reference.md
Generate PowerShell cmdlet reference at:
/Users/gh/git/bolt/documentation/bolt_cmdlet_reference.md
Generated shell command reference at:
/Users/gh/git/bolt/documentation/bolt_command_reference.md
Generated bolt-defaults.yaml reference at:
/Users/gh/git/bolt/documentation/bolt_defaults_reference.md
Generated privilege escalation doc at:
/Users/gh/git/bolt/documentation/privilege_escalation.md
Generated bolt-project.yaml reference at:
/Users/gh/git/bolt/documentation/bolt_project_reference.md
Generated transports configuration reference at:
/Users/gh/git/bolt/documentation/bolt_transports_reference.md
Generated packaged modules at:
/Users/gh/git/bolt/documentation/packaged_modules.md |
Without this patch, Bolt would needlessly keep from upgrading to the latest version of puppet-strings. This has knock on effects with gem dependencies that could prevent the newly deployed puppet-strings v5 from being resolved and available to use.
ghoneycutt
force-pushed
the
puppet_strings
branch
from
1173fac to
079772f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, Bolt would needlessly keep from upgrading to the
latest version of puppet-strings. This has knock on effects with gem
dependencies that could prevent the newly deployed puppet-strings v5
from being resolved and available to use.