Skip to content

Fixes in to_executorch for while #12062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Fixes in to_executorch for while #12062

merged 1 commit into from
Jul 1, 2025

Conversation

angelayi
Copy link
Contributor

Summary: Fixes while loop support in executorch AOT up until emitter (#8769 (comment))

Differential Revision: D77452951

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12062

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 88ba296 with merge base 7e28a04 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77452951

@angelayi angelayi mentioned this pull request Jun 27, 2025
Open
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Jun 27, 2025
@angelayi @facebook-github-bot
Fixes in to_executorch for while (pytorch#12062)
68c6d89 
Summary:

Fixes while loop support in executorch AOT up until emitter (pytorch#8769 (comment))

Differential Revision: D77452951
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77452951

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Jun 27, 2025
@angelayi @facebook-github-bot
Fixes in to_executorch for while (pytorch#12062)
d7b4344 
Summary:
Pull Request resolved: pytorch#12062

Fixes while loop support in executorch AOT up until emitter (pytorch#8769 (comment))

Differential Revision: D77452951
@JacobSzwejbka
Copy link
Contributor

Memory Planning didnt require any changes? Does it work with dynamic shape?

@angelayi
Copy link
Contributor Author

Memory Planning didnt require any changes? Does it work with dynamic shape?

My next error is in the emitter soo I guess memory planning doesn't require any changes? I didn't test for correctness though.

@vikasbalaga vikasbalaga mentioned this pull request Jun 30, 2025
Open
JacobSzwejbka
JacobSzwejbka approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure the xnnpack failures are not real

@angelayi angelayi force-pushed the export-D77452951 branch from d7b4344 to 3a0c881 Compare July 1, 2025 18:41
angelayi added a commit to angelayi/executorch-1 that referenced this pull request Jul 1, 2025
@angelayi @facebook-github-bot
Fixes in to_executorch for while (pytorch#12062)
3a0c881 
Summary:

Fixes while loop support in executorch AOT up until emitter (pytorch#8769 (comment))

Reviewed By: JacobSzwejbka

Differential Revision: D77452951
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77452951

@angelayi @facebook-github-bot
Fixes in to_executorch for while (pytorch#12062)
88ba296 
Summary:

Fixes while loop support in executorch AOT up until emitter (pytorch#8769 (comment))

Reviewed By: JacobSzwejbka

Differential Revision: D77452951
@angelayi angelayi force-pushed the export-D77452951 branch from 3a0c881 to 88ba296 Compare July 1, 2025 19:37
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77452951

@facebook-github-bot facebook-github-bot merged commit 9d599c9 into pytorch:main Jul 1, 2025
95 of 98 checks passed
BujSet pushed a commit to BujSet/executorch that referenced this pull request Jul 2, 2025
@angelayi @BujSet
Fixes in to_executorch for while
9cb91c6 
Differential Revision: D77452951

Pull Request resolved: pytorch#12062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angelayi @facebook-github-bot @JacobSzwejbka