Skip to content

fix is_inplace_node check #12071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

JacobSzwejbka
Copy link
Contributor

Summary: Oops it could be an edge op which failed the opOverload check. Switch to just hasattr

Differential Revision: D77462717

Copy link

pytorch-bot bot commented Jun 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12071

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs

As of commit 401e107 with merge base 22b9e59 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77462717

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 27, 2025
Summary:

Oops it could be an edge op which failed the opOverload check. Switch to just hasattr

Differential Revision: D77462717
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 27, 2025
Summary:

Oops it could be an edge op which failed the opOverload check. Switch to just hasattr

Reviewed By: larryliu0820

Differential Revision: D77462717
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 27, 2025
Summary:

Oops it could be an edge op which failed the opOverload check. Switch to just hasattr

Reviewed By: larryliu0820

Differential Revision: D77462717
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 27, 2025
Summary:

Oops it could be an edge op which failed the opOverload check. Switch to just hasattr

Reviewed By: larryliu0820

Differential Revision: D77462717
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77462717

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77462717

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 27, 2025
Summary:
Pull Request resolved: pytorch#12071

Oops it could be an edge op which failed the opOverload check. Switch to just hasattr

Reviewed By: larryliu0820

Differential Revision: D77462717
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77462717

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 27, 2025
Summary:
Pull Request resolved: pytorch#12071

Oops it could be an edge op which failed the opOverload check. Switch to just hasattr

Reviewed By: larryliu0820

Differential Revision: D77462717
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77462717

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 27, 2025
Summary:
Pull Request resolved: pytorch#12071

Oops it could be an edge op which failed the opOverload check. Switch to just hasattr

Reviewed By: larryliu0820

Differential Revision: D77462717
@JacobSzwejbka JacobSzwejbka force-pushed the export-D77462717 branch 2 times, most recently from 64fb1b4 to 844ea72 Compare July 1, 2025 18:55
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 1, 2025
Summary:

Oops it could be an edge op which failed the opOverload check. Switch to just hasattr

Reviewed By: larryliu0820

Differential Revision: D77462717
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77462717

Summary:

Oops it could be an edge op which failed the opOverload check. Switch to just hasattr

Reviewed By: larryliu0820

Differential Revision: D77462717
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77462717

@facebook-github-bot facebook-github-bot merged commit a909b83 into pytorch:main Jul 2, 2025
94 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants