[core] Deflake test_multiprocessing.py
#53802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codope
approved these changes
Jun 16, 2025
Merged
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
Deflakes the test by ensuring that results come in out of order for the `imap_unordered` tests instead of relying on random `time.sleep`s. In the process of rewriting the tests, I discovered a bug in the implementation. We weren't re-fetching available object refs from the queue once we had gotten at least one, which caused the tests to hang. Added a timeout to the `ray.wait` call so we continually check for new object refs to add to the batch. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
edoakes
added a commit
that referenced
this pull request
Jun 25, 2025
Meant to add comment in #53802, but there was a race condition with auto merge. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
Deflakes the test by ensuring that results come in out of order for the `imap_unordered` tests instead of relying on random `time.sleep`s. In the process of rewriting the tests, I discovered a bug in the implementation. We weren't re-fetching available object refs from the queue once we had gotten at least one, which caused the tests to hang. Added a timeout to the `ray.wait` call so we continually check for new object refs to add to the batch. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
Meant to add comment in ray-project#53802, but there was a race condition with auto merge. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Deflakes the test by ensuring that results come in out of order for the `imap_unordered` tests instead of relying on random `time.sleep`s. In the process of rewriting the tests, I discovered a bug in the implementation. We weren't re-fetching available object refs from the queue once we had gotten at least one, which caused the tests to hang. Added a timeout to the `ray.wait` call so we continually check for new object refs to add to the batch. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Meant to add comment in #53802, but there was a race condition with auto merge. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deflakes the test by ensuring that results come in out of order for the
imap_unorderedtests instead of relying on randomtime.sleeps.In the process of rewriting the tests, I discovered a bug in the implementation. We weren't re-fetching available object refs from the queue once we had gotten at least one, which caused the tests to hang. Added a timeout to the
ray.waitcall so we continually check for new object refs to add to the batch.