[core] deleting unused code from plasma client #53814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: irabbani <irabbani@anyscale.com>
|
MacOS build failures are unrelated. The build is broken on HEAD/master. Windows tests passed. |
edoakes
approved these changes
Jun 16, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
The code looks like a premature optimization that was added as #9367 5 years ago and it was never used. It might be useful to make the Read/Write methods on the plasma socket async, but without actual data to support the usefulness of this, we should delete the code. Signed-off-by: irabbani <irabbani@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
rebel-scottlee
pushed a commit
to rebellions-sw/ray
that referenced
this pull request
Jun 21, 2025
The code looks like a premature optimization that was added as ray-project#9367 5 years ago and it was never used. It might be useful to make the Read/Write methods on the plasma socket async, but without actual data to support the usefulness of this, we should delete the code. Signed-off-by: irabbani <irabbani@anyscale.com> Signed-off-by: Scott Lee <scott.lee@rebellions.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code looks like a premature optimization that was added as #9367 5 years ago and it was never used.
It might be useful to make the Read/Write methods on the plasma socket async, but without actual data to support the usefulness of this, we should delete the code.